Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3f29862 authored by Jack Yu's avatar Jack Yu
Browse files

Cleaned up the flag data_rat_metric_enabled 

Cleaned up the 24Q3 flag data_rat_metric_enabled

Test: atest FrameworksTelephonyTests
Test: Basic telephony functionality tests
Bug: 318519337
Flag: EXEMPT flag cleanup
Change-Id: Ibf9e9055681c0d97af3335f7ba8edf9832e21137
parent 7ab46564

flags/data.aconfig

+0 −8
Original line number Diff line number Diff line
@@ -41,14 +41,6 @@ flag { 
  bug:"286171724"

}



# OWNER=jackyu TARGET=24Q3

flag {

  name: "data_rat_metric_enabled"

  namespace: "telephony"

  description: "Write DataRatStateChanged atom"

  bug:"318519337"

}



# OWNER=jackyu TARGET=24Q4

flag {

  name: "dds_callback"

src/java/com/android/internal/telephony/metrics/DataConnectionStateTracker.java

+1 −5
Original line number Diff line number Diff line
@@ -16,8 +16,6 @@ 


package com.android.internal.telephony.metrics;



import static com.android.internal.telephony.flags.Flags.dataRatMetricEnabled;



import android.os.Handler;

import android.os.HandlerExecutor;

import android.os.HandlerThread;
@@ -235,9 +233,7 @@ public class DataConnectionStateTracker { 


        @Override

        public void onActiveDataSubscriptionIdChanged(int subId) {

            if (dataRatMetricEnabled()) {

            logRATChanges(subId);

            }

            mActiveDataSubId = subId;

        }

src/java/com/android/internal/telephony/metrics/ServiceStateStats.java

+1 −4
Original line number Diff line number Diff line
@@ -21,7 +21,6 @@ import static android.telephony.TelephonyManager.DATA_CONNECTED; 
import static com.android.internal.telephony.TelephonyStatsLog.VOICE_CALL_SESSION__BEARER_AT_END__CALL_BEARER_CS;

import static com.android.internal.telephony.TelephonyStatsLog.VOICE_CALL_SESSION__BEARER_AT_END__CALL_BEARER_IMS;

import static com.android.internal.telephony.TelephonyStatsLog.VOICE_CALL_SESSION__BEARER_AT_END__CALL_BEARER_UNKNOWN;

import static com.android.internal.telephony.flags.Flags.dataRatMetricEnabled;



import android.annotation.NonNull;

import android.annotation.Nullable;
@@ -150,10 +149,8 @@ public class ServiceStateStats extends DataNetworkControllerCallback { 
                    prevState, now, getDataServiceSwitch(prevState.mServiceState, newState));

        }



        if (dataRatMetricEnabled()) {

        writeDataRatAtom(serviceState);

    }

    }



    /** Updates the fold state of the device for the current service state. */

    public void onFoldStateChanged(int foldState) {