Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f3ec3e90 authored by Malcolm Chen's avatar Malcolm Chen
Browse files

Clean up SubMgr#getOpportunisticSubscriptions. 

Remove param slotIndex, which is not used.

Bug: 117832560
Bug: 117830188
Test: build
Change-Id: Iac892044d336542b103eca2908420d8fd16e59c8
parent 54b3d647

src/java/com/android/internal/telephony/SubscriptionController.java

+1 −1
Original line number Diff line number Diff line
@@ -2322,7 +2322,7 @@ public class SubscriptionController extends ISub.Stub { 
    }



    @Override

    public List<SubscriptionInfo> getOpportunisticSubscriptions(int slotId, String callingPackage) {

    public List<SubscriptionInfo> getOpportunisticSubscriptions(String callingPackage) {

        return getSubscriptionInfoListFromCacheHelper(

                callingPackage, mCacheOpportunisticSubInfoList);

    }

tests/telephonytests/src/com/android/internal/telephony/SubscriptionControllerTest.java

+2 −2
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ public class SubscriptionControllerTest extends TelephonyTest { 
        // Neither sub1 or sub2 are opportunistic. So getOpportunisticSubscriptions

        // should return empty list and no callback triggered.

        List<SubscriptionInfo> opptSubList = mSubscriptionControllerUT

                .getOpportunisticSubscriptions(0, mCallingPackage);

                .getOpportunisticSubscriptions(mCallingPackage);



        assertTrue(opptSubList.isEmpty());

        verify(mTelephonyRegisteryMock, times(0))
@@ -360,7 +360,7 @@ public class SubscriptionControllerTest extends TelephonyTest { 
        verify(mTelephonyRegisteryMock, times(1))

                .notifyOpportunisticSubscriptionInfoChanged();

        opptSubList = mSubscriptionControllerUT

                .getOpportunisticSubscriptions(0, mCallingPackage);

                .getOpportunisticSubscriptions(mCallingPackage);

        assertEquals(1, opptSubList.size());

        assertEquals("test2", opptSubList.get(0).getIccId());