Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e5033b77 authored by Jack Yu's avatar Jack Yu
Browse files

Fixed incorrect card name shown up 

The card name "CARD %d" is shown in settings. Fixed by appending
the subscription id to the display name.

Fix: 278570149
Test: atest SubscriptionManagerServiceTest
Change-Id: Icf96e90da21544c1549b8a16fb9579ba0fcbf5d1
parent 8d28545a

src/java/com/android/internal/telephony/subscription/SubscriptionManagerService.java

+3 −2
Original line number Diff line number Diff line
@@ -3848,9 +3848,10 @@ public class SubscriptionManagerService extends ISub.Stub { 
                    // If iccId is new, add a subscription record in the database so it can be

                    // activated later. (Pre-U behavior)

                    subId = insertSubscriptionInfo(IccUtils.stripTrailingFs(iccId),

                            SubscriptionManager.INVALID_SIM_SLOT_INDEX,

                            mContext.getResources().getString(R.string.default_card_name),

                            SubscriptionManager.INVALID_SIM_SLOT_INDEX, "",

                            SubscriptionManager.SUBSCRIPTION_TYPE_LOCAL_SIM);

                    mSubscriptionDatabaseManager.setDisplayName(subId,

                            mContext.getResources().getString(R.string.default_card_name, subId));

                    log("updateSimStateForInactivePort: Insert a new subscription for inactive SIM."

                            + " subId=" + subId);

                }

tests/telephonytests/src/com/android/internal/telephony/subscription/SubscriptionDatabaseManagerTest.java

+1 −1
Original line number Diff line number Diff line
@@ -70,7 +70,7 @@ import java.util.concurrent.Executor; 
@TestableLooper.RunWithLooper

public class SubscriptionDatabaseManagerTest extends TelephonyTest {



    static final String FAKE_DEFAULT_CARD_NAME = "CARD NAME";

    static final String FAKE_DEFAULT_CARD_NAME = "CARD %d";

    static final String FAKE_ICCID1 = "123456";

    static final String FAKE_ICCID2 = "456789";

    static final String FAKE_PHONE_NUMBER1 = "6502530000";

tests/telephonytests/src/com/android/internal/telephony/subscription/SubscriptionManagerServiceTest.java

+1 −1
Original line number Diff line number Diff line
@@ -2193,7 +2193,7 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 
                .getSubscriptionInfoInternal(1);

        assertThat(subInfo.getSimSlotIndex()).isEqualTo(SubscriptionManager.INVALID_SIM_SLOT_INDEX);

        assertThat(subInfo.getIccId()).isEqualTo(FAKE_ICCID1);

        assertThat(subInfo.getDisplayName()).isEqualTo(FAKE_DEFAULT_CARD_NAME);

        assertThat(subInfo.getDisplayName()).isEqualTo("CARD 1");

        assertThat(subInfo.getPortIndex()).isEqualTo(0);

    }