Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddee2819 authored by Ling Ma's avatar Ling Ma
Browse files

Clean up log spam

Test: basic voice + data
Flag: EXEMPT refactor
Change-Id: I538af9eee9f51ffde5b6df4acaac8ee113e1b031
parent d304a07e
Loading
Loading
Loading
Loading
+20 −34
Original line number Diff line number Diff line
@@ -247,37 +247,27 @@ public class NetworkTypeController extends StateMachine {
    private final ConnectivityManager.NetworkCallback mNetworkCallback =
            new ConnectivityManager.NetworkCallback() {
                @Override
                public void onAvailable(Network network) {
                    log("On Available: " + network);
                    if (network != null) {
                public void onAvailable(@NonNull Network network) {
                    if (mConnectivityManager != null) {
                        NetworkCapabilities capabilities =
                                mConnectivityManager.getNetworkCapabilities(network);
                            updateBandwidthConstrainedStatus(capabilities);
                        } else {
                            log("network is null");
                        if (capabilities != null) {
                            updateBandwidthConstrainedStatus(
                                    isBandwidthConstrainedCapabilitySupported(capabilities));
                        }
                    }
                }

                @Override
                public void onCapabilitiesChanged(Network network,
                        NetworkCapabilities networkCapabilities) {
                    log("onCapabilitiesChanged: " + network);
                    if (network != null) {
                        updateBandwidthConstrainedStatus(networkCapabilities);
                    } else {
                        log("network is null");
                    }
                public void onCapabilitiesChanged(@NonNull Network network,
                        @NonNull NetworkCapabilities networkCapabilities) {
                    updateBandwidthConstrainedStatus(
                            isBandwidthConstrainedCapabilitySupported(networkCapabilities));
                }

                @Override
                public void onLost(Network network) {
                    log("Network Lost");
                    if (mIsSatelliteConstrainedData) {
                        mIsSatelliteConstrainedData = false;
                        mDisplayInfoController.updateTelephonyDisplayInfo();
                    }
                public void onLost(@NonNull Network network) {
                    updateBandwidthConstrainedStatus(false);
                }
            };

@@ -296,17 +286,13 @@ public class NetworkTypeController extends StateMachine {
        }
    }

    private void updateBandwidthConstrainedStatus(NetworkCapabilities capabilities) {
        if (capabilities != null) {
            boolean isConstrained = isBandwidthConstrainedCapabilitySupported(capabilities);
    private void updateBandwidthConstrainedStatus(boolean isConstrained) {
        if (isConstrained != mIsSatelliteConstrainedData) {
            mIsSatelliteConstrainedData = isConstrained;
                log("Update network type because satellite constrained data status changed to "
            log("Reset timers because satellite constrained data status changed to "
                    + mIsSatelliteConstrainedData);
                mDisplayInfoController.updateTelephonyDisplayInfo();
            }
        } else {
            log("capabilities is null");
            resetAllTimers();
            transitionToCurrentState();
        }
    }