Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit da02d1d7 authored by Malcolm Chen's avatar Malcolm Chen
Browse files

Adding validationBeforeSwitchSupported in phoneCapability. 

Bug: 118348832
Test: sanity
Change-Id: I92f63aaaf0faa3f48f1bb95e8871631c7bec6aad
Merged-In: I92f63aaaf0faa3f48f1bb95e8871631c7bec6aad
parent c710b1fe

src/java/com/android/internal/telephony/PhoneConfigurationModels.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -40,10 +40,10 @@ class PhoneConfigurationModels { 
        List<ModemInfo> logicalModemList = new ArrayList<>();

        List<ModemInfo> logicalModemList = new ArrayList<>();

        logicalModemList.add(modemInfo1);

        logicalModemList.add(modemInfo1);

        logicalModemList.add(modemInfo2);

        logicalModemList.add(modemInfo2);

        DSDS_CAPABILITY = new PhoneCapability(1, 2, 0, logicalModemList);

        DSDS_CAPABILITY = new PhoneCapability(1, 2, 0, logicalModemList, false);





        logicalModemList = new ArrayList<>();

        logicalModemList = new ArrayList<>();

        logicalModemList.add(modemInfo1);

        logicalModemList.add(modemInfo1);

        SSSS_CAPABILITY = new PhoneCapability(1, 1, 0, logicalModemList);

        SSSS_CAPABILITY = new PhoneCapability(1, 1, 0, logicalModemList, false);

    }

    }

}
 
}

src/java/com/android/internal/telephony/RadioConfigResponse.java

+3 −1
Original line number Original line Diff line number Diff line
@@ -121,6 +121,7 @@ public class RadioConfigResponse extends IRadioConfigResponse.Stub { 
        int maxActiveVoiceCalls = 0;

        int maxActiveVoiceCalls = 0;

        int maxActiveData = phoneCapability.maxActiveData;

        int maxActiveData = phoneCapability.maxActiveData;

        int max5G = 0;

        int max5G = 0;

        boolean validationBeforeSwitchSupported = phoneCapability.isInternetLingeringSupported;

        List<ModemInfo> logicalModemList = new ArrayList();

        List<ModemInfo> logicalModemList = new ArrayList();





        for (android.hardware.radio.config.V1_1.ModemInfo

        for (android.hardware.radio.config.V1_1.ModemInfo
@@ -128,7 +129,8 @@ public class RadioConfigResponse extends IRadioConfigResponse.Stub { 
            logicalModemList.add(new ModemInfo(modemInfo.modemId));

            logicalModemList.add(new ModemInfo(modemInfo.modemId));

        }

        }





        return new PhoneCapability(maxActiveVoiceCalls, maxActiveData, max5G, logicalModemList);

        return new PhoneCapability(maxActiveVoiceCalls, maxActiveData, max5G, logicalModemList,

                validationBeforeSwitchSupported);

    }

    }

    /**

    /**

     * Response function for IRadioConfig.getPhoneCapability().

     * Response function for IRadioConfig.getPhoneCapability().

tests/telephonytests/src/com/android/internal/telephony/PhoneCapabilityTest.java

+4 −4
Original line number Original line Diff line number Diff line
@@ -41,7 +41,7 @@ public class PhoneCapabilityTest { 
        logicalModemList.add(modemInfo);

        logicalModemList.add(modemInfo);





        PhoneCapability capability = new PhoneCapability(maxActiveVoiceCalls, maxActiveData, max5G,

        PhoneCapability capability = new PhoneCapability(maxActiveVoiceCalls, maxActiveData, max5G,

                logicalModemList);

                logicalModemList, false);





        assertEquals(maxActiveVoiceCalls, capability.maxActiveVoiceCalls);

        assertEquals(maxActiveVoiceCalls, capability.maxActiveVoiceCalls);

        assertEquals(maxActiveData, capability.maxActiveData);

        assertEquals(maxActiveData, capability.maxActiveData);
@@ -49,9 +49,9 @@ public class PhoneCapabilityTest { 
        assertEquals(1, capability.logicalModemList.size());

        assertEquals(1, capability.logicalModemList.size());

        assertEquals(modemInfo, capability.logicalModemList.get(0));

        assertEquals(modemInfo, capability.logicalModemList.get(0));

        PhoneCapability toCompare = new PhoneCapability(

        PhoneCapability toCompare = new PhoneCapability(

                maxActiveVoiceCalls + 1, maxActiveData - 1, max5G, logicalModemList);

                maxActiveVoiceCalls + 1, maxActiveData - 1, max5G, logicalModemList, false);

        assertEquals(capability, new PhoneCapability(

        assertEquals(capability, new PhoneCapability(

                maxActiveVoiceCalls, maxActiveData, max5G, logicalModemList));

                maxActiveVoiceCalls, maxActiveData, max5G, logicalModemList, false));

        assertNotEquals(capability, toCompare);

        assertNotEquals(capability, toCompare);

    }

    }
@@ -66,7 +66,7 @@ public class PhoneCapabilityTest { 
        logicalModemList.add(modemInfo);

        logicalModemList.add(modemInfo);





        PhoneCapability capability = new PhoneCapability(maxActiveVoiceCalls, maxActiveData, max5G,

        PhoneCapability capability = new PhoneCapability(maxActiveVoiceCalls, maxActiveData, max5G,

                logicalModemList);

                logicalModemList, false);





        Parcel parcel = Parcel.obtain();

        Parcel parcel = Parcel.obtain();

        capability.writeToParcel(parcel, 0);

        capability.writeToParcel(parcel, 0);

tests/telephonytests/src/com/android/internal/telephony/TelephonyRegistryTest.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -103,7 +103,7 @@ public class TelephonyRegistryTest extends TelephonyTest { 
    public void testPhoneCapabilityChanged() {

    public void testPhoneCapabilityChanged() {

        // mTelephonyRegistry.listen with notifyNow = true should trigger callback immediately.

        // mTelephonyRegistry.listen with notifyNow = true should trigger callback immediately.

        setReady(false);

        setReady(false);

        PhoneCapability phoneCapability = new PhoneCapability(1, 2, 3, null);

        PhoneCapability phoneCapability = new PhoneCapability(1, 2, 3, null, false);

        mTelephonyRegistry.notifyPhoneCapabilityChanged(phoneCapability);

        mTelephonyRegistry.notifyPhoneCapabilityChanged(phoneCapability);

        mTelephonyRegistry.listen(mContext.getOpPackageName(),

        mTelephonyRegistry.listen(mContext.getOpPackageName(),

                mPhoneStateListener.callback,

                mPhoneStateListener.callback,
@@ -113,7 +113,7 @@ public class TelephonyRegistryTest extends TelephonyTest { 




        // notifyPhoneCapabilityChanged with a new capability. Callback should be triggered.

        // notifyPhoneCapabilityChanged with a new capability. Callback should be triggered.

        setReady(false);

        setReady(false);

        phoneCapability = new PhoneCapability(3, 2, 2, null);

        phoneCapability = new PhoneCapability(3, 2, 2, null, false);

        mTelephonyRegistry.notifyPhoneCapabilityChanged(phoneCapability);

        mTelephonyRegistry.notifyPhoneCapabilityChanged(phoneCapability);

        waitUntilReady();

        waitUntilReady();

        assertEquals(phoneCapability, mPhoneCapability);

        assertEquals(phoneCapability, mPhoneCapability);