Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d377f982 authored by joonhunshin's avatar joonhunshin
Browse files

move the responsibility of calling updateImsServiceConfig back to the ImsPhoneCallTracker 

The ImsProvisioningController has no information as to the current state
of the ImsPhonCallTracker and can not wait to send the configs until after the initial set-up from the ImsPhoneCallTracker#startListeningForCalls method.
This is causing some conditions where ImsProvisioningController calls ImsManager#updateImsSericeConfig before the ImsPhoneCallTracker is able to set up the interface properly.

Bug: 219992992
Test: atest
Change-Id: I9694cd7ce58315dce99ac7ae5df12bac34da5c5d
Merged-In: I9694cd7ce58315dce99ac7ae5df12bac34da5c5d
parent 837f0ebd

src/java/com/android/internal/telephony/imsphone/ImsPhoneCallTracker.java

+8 −4
Original line number Original line Diff line number Diff line
@@ -4034,10 +4034,14 @@ public class ImsPhoneCallTracker extends CallTracker implements ImsPullCall { 
        @Override

        @Override

        public void onProvisioningIntChanged(int item, int value) {

        public void onProvisioningIntChanged(int item, int value) {

            sendConfigChangedIntent(item, Integer.toString(value));

            sendConfigChangedIntent(item, Integer.toString(value));



            if ((mImsManager != null)

            // mImsManager.updateImsServiceConfig() will be called by ImsProvisioningController

                    && (item == ImsConfig.ConfigConstants.VOICE_OVER_WIFI_SETTING_ENABLED

            // when provisioning status is changed. The implementation is removed to avoid calling

                    || item == ImsConfig.ConfigConstants.VLT_SETTING_ENABLED

            // the updateImsServiceConfig twice.

                    || item == ImsConfig.ConfigConstants.LVC_SETTING_ENABLED)) {

                // Update Ims Service state to make sure updated provisioning values take effect

                // immediately.

                updateImsServiceConfig();

            }

        }

        }





        @Override

        @Override