Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d301e973 authored by yinxu's avatar yinxu
Browse files

Switch to Context#sendStickyBroadcastAsUser 

Bug: 146350138
Test: Telephony Unit Tests
Change-Id: Ifbcdcaa77f5ca6f373922ef273ef282d24840071
parent bf1824dd

src/java/com/android/internal/telephony/GsmCdmaPhone.java

+3 −4
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ import static com.android.internal.telephony.CommandsInterface.SERVICE_CLASS_VOI 


import android.annotation.NonNull;

import android.annotation.Nullable;

import android.app.ActivityManager;

import android.compat.annotation.UnsupportedAppUsage;

import android.content.BroadcastReceiver;

import android.content.ContentValues;
@@ -776,7 +775,7 @@ public class GsmCdmaPhone extends Phone { 
        Intent intent = new Intent(TelephonyIntents.ACTION_EMERGENCY_CALLBACK_MODE_CHANGED);

        intent.putExtra(PhoneConstants.PHONE_IN_ECM_STATE, isInEcm());

        SubscriptionManager.putPhoneIdAndSubIdExtra(intent, getPhoneId());

        ActivityManager.broadcastStickyIntent(intent, UserHandle.USER_ALL);

        mContext.sendStickyBroadcastAsUser(intent, UserHandle.ALL);

        logi("sendEmergencyCallbackModeChange");

    }
@@ -791,7 +790,7 @@ public class GsmCdmaPhone extends Phone { 
            Intent intent = new Intent(TelephonyIntents.ACTION_EMERGENCY_CALL_STATE_CHANGED);

            intent.putExtra(PhoneConstants.PHONE_IN_EMERGENCY_CALL, callActive);

            SubscriptionManager.putPhoneIdAndSubIdExtra(intent, getPhoneId());

            ActivityManager.broadcastStickyIntent(intent, UserHandle.USER_ALL);

            mContext.sendStickyBroadcastAsUser(intent, UserHandle.ALL);

            if (DBG) Rlog.d(LOG_TAG, "sendEmergencyCallStateChange: callActive " + callActive);

        }

    }
@@ -3721,7 +3720,7 @@ public class GsmCdmaPhone extends Phone { 
        Intent intent = new Intent(TelephonyIntents.ACTION_RADIO_TECHNOLOGY_CHANGED);

        intent.putExtra(PhoneConstants.PHONE_NAME_KEY, getPhoneName());

        SubscriptionManager.putPhoneIdAndSubIdExtra(intent, mPhoneId);

        ActivityManager.broadcastStickyIntent(intent, UserHandle.USER_ALL);

        mContext.sendStickyBroadcastAsUser(intent, UserHandle.ALL);

    }



    private void switchVoiceRadioTech(int newVoiceRadioTech) {

src/java/com/android/internal/telephony/IntentBroadcaster.java

+3 −4
Original line number Diff line number Diff line
@@ -16,7 +16,6 @@ 


package com.android.internal.telephony;



import android.app.ActivityManager;

import android.content.BroadcastReceiver;

import android.content.Context;

import android.content.Intent;
@@ -56,7 +55,7 @@ public class IntentBroadcaster { 
                        logd("Rebroadcasting intent " + i.getAction() + " "

                                + i.getStringExtra(IccCardConstants.INTENT_KEY_ICC_STATE)

                                + " for slotId " + pair.getKey());

                        ActivityManager.broadcastStickyIntent(i, UserHandle.USER_ALL);

                        context.sendStickyBroadcastAsUser(intent, UserHandle.ALL);

                    }

                }

            }
@@ -86,12 +85,12 @@ public class IntentBroadcaster { 
     * Wrapper for ActivityManager.broadcastStickyIntent() that also stores intent to be rebroadcast

     * on USER_UNLOCKED

     */

    public void broadcastStickyIntent(Intent intent, int phoneId) {

    public void broadcastStickyIntent(Context context, Intent intent, int phoneId) {

        logd("Broadcasting and adding intent for rebroadcast: " + intent.getAction() + " "

                + intent.getStringExtra(IccCardConstants.INTENT_KEY_ICC_STATE)

                + " for phoneId " + phoneId);

        synchronized (mRebroadcastIntents) {

            ActivityManager.broadcastStickyIntent(intent, UserHandle.USER_ALL);

            context.sendStickyBroadcastAsUser(intent, UserHandle.ALL);

            mRebroadcastIntents.put(phoneId, intent);

        }

    }

src/java/com/android/internal/telephony/SubscriptionInfoUpdater.java

+1 −1
Original line number Diff line number Diff line
@@ -1092,7 +1092,7 @@ public class SubscriptionInfoUpdater extends Handler { 
        SubscriptionManager.putPhoneIdAndSubIdExtra(i, phoneId);

        logd("Broadcasting intent ACTION_SIM_STATE_CHANGED " + state + " reason " + reason +

                " for phone: " + phoneId);

        IntentBroadcaster.getInstance().broadcastStickyIntent(i, phoneId);

        IntentBroadcaster.getInstance().broadcastStickyIntent(sContext, i, phoneId);

    }



    private void broadcastSimCardStateChanged(int phoneId, int state) {

src/java/com/android/internal/telephony/imsphone/ImsPhone.java

+1 −2
Original line number Diff line number Diff line
@@ -39,7 +39,6 @@ import static com.android.internal.telephony.CommandsInterface.SERVICE_CLASS_NON 
import static com.android.internal.telephony.CommandsInterface.SERVICE_CLASS_VOICE;



import android.app.Activity;

import android.app.ActivityManager;

import android.app.Notification;

import android.app.NotificationManager;

import android.app.PendingIntent;
@@ -1698,7 +1697,7 @@ public class ImsPhone extends ImsPhoneBase { 
        Intent intent = new Intent(TelephonyIntents.ACTION_EMERGENCY_CALLBACK_MODE_CHANGED);

        intent.putExtra(PhoneConstants.PHONE_IN_ECM_STATE, isInEcm());

        SubscriptionManager.putPhoneIdAndSubIdExtra(intent, getPhoneId());

        ActivityManager.broadcastStickyIntent(intent, UserHandle.USER_ALL);

        mContext.sendStickyBroadcastAsUser(intent, UserHandle.ALL);

        if (DBG) logd("sendEmergencyCallbackModeChange: isInEcm=" + isInEcm());

    }

tests/telephonytests/src/com/android/internal/telephony/GsmCdmaPhoneTest.java

+8 −56
Original line number Diff line number Diff line
@@ -41,13 +41,9 @@ import static org.mockito.Mockito.spy; 
import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;



import android.app.Activity;

import android.app.IApplicationThread;

import android.content.IIntentReceiver;

import android.content.Intent;

import android.content.SharedPreferences;

import android.os.AsyncResult;

import android.os.Bundle;

import android.os.Handler;

import android.os.Message;

import android.os.Process;
@@ -880,19 +876,8 @@ public class GsmCdmaPhoneTest extends TelephonyTest { 
        // verify ACTION_EMERGENCY_CALLBACK_MODE_CHANGED

        ArgumentCaptor<Intent> intentArgumentCaptor = ArgumentCaptor.forClass(Intent.class);

        try {

            verify(mIActivityManager, atLeast(1)).broadcastIntent(eq((IApplicationThread) null),

                    intentArgumentCaptor.capture(),

                    eq((String) null),

                    eq((IIntentReceiver) null),

                    eq(Activity.RESULT_OK),

                    eq((String) null),

                    eq((Bundle) null),

                    eq((String[]) null),

                    anyInt(),

                    eq((Bundle) null),

                    eq(false),

                    eq(true),

                    anyInt());

            verify(mContext, atLeast(1)).sendStickyBroadcastAsUser(intentArgumentCaptor.capture(),

                    any());

        } catch(Exception e) {

            fail("Unexpected exception: " + e.getStackTrace());

        }
@@ -914,19 +899,8 @@ public class GsmCdmaPhoneTest extends TelephonyTest { 


        // verify ACTION_EMERGENCY_CALLBACK_MODE_CHANGED

        try {

            verify(mIActivityManager, atLeast(2)).broadcastIntent(eq((IApplicationThread) null),

                    intentArgumentCaptor.capture(),

                    eq((String) null),

                    eq((IIntentReceiver) null),

                    eq(Activity.RESULT_OK),

                    eq((String) null),

                    eq((Bundle) null),

                    eq((String[]) null),

                    anyInt(),

                    eq((Bundle) null),

                    eq(false),

                    eq(true),

                    anyInt());

            verify(mContext, atLeast(2)).sendStickyBroadcastAsUser(intentArgumentCaptor.capture(),

                    any());

        } catch(Exception e) {

            fail("Unexpected exception: " + e.getStackTrace());

        }
@@ -968,19 +942,8 @@ public class GsmCdmaPhoneTest extends TelephonyTest { 
        // verify ACTION_EMERGENCY_CALLBACK_MODE_CHANGED

        ArgumentCaptor<Intent> intentArgumentCaptor = ArgumentCaptor.forClass(Intent.class);

        try {

            verify(mIActivityManager, atLeast(1)).broadcastIntent(eq((IApplicationThread) null),

                    intentArgumentCaptor.capture(),

                    eq((String) null),

                    eq((IIntentReceiver) null),

                    eq(Activity.RESULT_OK),

                    eq((String) null),

                    eq((Bundle) null),

                    eq((String[]) null),

                    anyInt(),

                    eq((Bundle) null),

                    eq(false),

                    eq(true),

                    anyInt());

            verify(mContext, atLeast(1)).sendStickyBroadcastAsUser(intentArgumentCaptor.capture(),

                    any());

        } catch (Exception e) {

            fail("Unexpected exception: " + e.getStackTrace());

        }
@@ -1002,19 +965,8 @@ public class GsmCdmaPhoneTest extends TelephonyTest { 


        // verify ACTION_EMERGENCY_CALLBACK_MODE_CHANGED

        try {

            verify(mIActivityManager, atLeast(2)).broadcastIntent(eq((IApplicationThread) null),

                    intentArgumentCaptor.capture(),

                    eq((String) null),

                    eq((IIntentReceiver) null),

                    eq(Activity.RESULT_OK),

                    eq((String) null),

                    eq((Bundle) null),

                    eq((String[]) null),

                    anyInt(),

                    eq((Bundle) null),

                    eq(false),

                    eq(true),

                    anyInt());

            verify(mContext, atLeast(2)).sendStickyBroadcastAsUser(intentArgumentCaptor.capture(),

                    any());

        } catch (Exception e) {

            fail("Unexpected exception: " + e.getStackTrace());

        }