Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cce98d06 authored by junyulai's avatar junyulai
Browse files

[SP13] Add unit test for VtDataUsageProvider 

Test: atest ImsPhoneCallTrackerTest
Fix: 143923500

Change-Id: I78513cc4d9cad2fdc31df0acb3c49ba3356b8ca2
parent d4ab97fa

src/java/com/android/internal/telephony/imsphone/ImsPhoneCallTracker.java

+8 −3
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.internal.telephony.imsphone;



import static com.android.internal.annotations.VisibleForTesting.Visibility.PRIVATE;

import static com.android.internal.telephony.Phone.CS_FALLBACK;



import android.annotation.NonNull;
@@ -257,10 +258,13 @@ public class ImsPhoneCallTracker extends CallTracker implements ImsPullCall { 
        }

    }



    /**

     * A class implementing {@link AbstractNetworkStatsProvider} to report VT data usage to system.

     */

    // TODO: 1. Directly reports diff in updateVtDataUsage.

    //       2. Remove unused getVtDataUsage.

    //       3. Add tests.

    private class VtDataUsageProvider extends AbstractNetworkStatsProvider {

    @VisibleForTesting(visibility = PRIVATE)

    public class VtDataUsageProvider extends AbstractNetworkStatsProvider {

        private int mToken = 0;

        private NetworkStats mIfaceSnapshot = new NetworkStats(0L, 0);

        private NetworkStats mUidSnapshot = new NetworkStats(0L, 0);
@@ -3658,7 +3662,8 @@ public class ImsPhoneCallTracker extends CallTracker implements ImsPullCall { 
     * @param call The IMS call

     * @param dataUsage The aggregated data usage for the call

     */

    private void updateVtDataUsage(ImsCall call, long dataUsage) {

    @VisibleForTesting(visibility = PRIVATE)

    public void updateVtDataUsage(ImsCall call, long dataUsage) {

        long oldUsage = 0L;

        if (mVtDataUsageMap.containsKey(call.uniqueId)) {

            oldUsage = mVtDataUsageMap.get(call.uniqueId);

tests/telephonytests/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ android_test { 
        "frameworks-base-testutils",

        "guava",

        "mockito-target-minus-junit4",

        "net-tests-utils",

        "platform-test-annotations",

        "services.core",

        "services.net",

tests/telephonytests/src/com/android/internal/telephony/imsphone/ImsPhoneCallTrackerTest.java

+77 −0
Original line number Diff line number Diff line
@@ -15,6 +15,15 @@ 
 */

package com.android.internal.telephony.imsphone;



import static android.net.NetworkStats.DEFAULT_NETWORK_YES;

import static android.net.NetworkStats.METERED_YES;

import static android.net.NetworkStats.ROAMING_NO;

import static android.net.NetworkStats.SET_FOREGROUND;

import static android.net.NetworkStats.TAG_NONE;

import static android.net.NetworkStats.UID_ALL;



import static com.android.testutils.NetworkStatsUtilsKt.assertNetworkStatsEquals;



import static junit.framework.TestCase.fail;



import static org.junit.Assert.assertEquals;
@@ -33,6 +42,7 @@ import static org.mockito.Mockito.eq; 
import static org.mockito.Mockito.isNull;

import static org.mockito.Mockito.mock;

import static org.mockito.Mockito.never;

import static org.mockito.Mockito.reset;

import static org.mockito.Mockito.spy;

import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;
@@ -41,6 +51,8 @@ import static org.mockito.Mockito.when; 
import android.content.Context;

import android.content.SharedPreferences;

import android.content.pm.PackageManager;

import android.net.NetworkStats;

import android.net.NetworkStats.Entry;

import android.net.netstats.provider.NetworkStatsProviderCallback;

import android.os.Bundle;

import android.os.Message;
@@ -74,6 +86,7 @@ import com.android.internal.telephony.CommandsInterface; 
import com.android.internal.telephony.Connection;

import com.android.internal.telephony.PhoneConstants;

import com.android.internal.telephony.TelephonyTest;

import com.android.internal.telephony.imsphone.ImsPhoneCallTracker.VtDataUsageProvider;



import org.junit.After;

import org.junit.Assert;
@@ -96,6 +109,8 @@ public class ImsPhoneCallTrackerTest extends TelephonyTest { 
    private ImsCall mImsCall;

    private ImsCall mSecondImsCall;

    private Bundle mBundle = new Bundle();

    private final ArgumentCaptor<VtDataUsageProvider> mVtDataUsageProviderCaptor =

            ArgumentCaptor.forClass(VtDataUsageProvider.class);

    @Mock

    private ImsCallSession mImsCallSession;

    @Mock
@@ -231,6 +246,8 @@ public class ImsPhoneCallTrackerTest extends TelephonyTest { 
                "service not allowed in this location",

                ImsReasonInfo.CODE_WFC_SERVICE_NOT_AVAILABLE_IN_THIS_LOCATION);

        mCTUT.setDataEnabled(true);

        verify(mStatsManager).registerNetworkStatsProvider(anyString(),

                mVtDataUsageProviderCaptor.capture());



        logd("ImsPhoneCallTracker initiated");

        processAllMessages();
@@ -1012,6 +1029,66 @@ public class ImsPhoneCallTrackerTest extends TelephonyTest { 
        mCTUT.getImsCallListener().onCallHoldFailed(mImsPhoneConnection.getImsCall(), info);

    }



    @Test

    @SmallTest

    public void testVtDataUsageProvider() {

        final VtDataUsageProvider provider = mVtDataUsageProviderCaptor.getValue();



        provider.requestStatsUpdate(11);



        // Verify that requestStatsUpdate triggers onStatsUpdated, where the initial token should

        // be reported with current stats.

        assertVtDataUsageUpdated(0, 0, 0);



        // Establish a MT call.

        testImsMTCallAccept();

        final ImsPhoneConnection connection = mCTUT.mForegroundCall.getFirstConnection();

        final ImsCall call = connection.getImsCall();

        mCTUT.updateVtDataUsage(call, 51);



        // Make another request, and verify stats updated accordingly, with previously issued token.

        reset(mVtDataUsageProviderCb);

        provider.requestStatsUpdate(13);

        assertVtDataUsageUpdated(11, 25, 25);



        // Update accumulated data usage twice. updateVtDataUsage takes accumulated stats from

        // boot up.

        reset(mVtDataUsageProviderCb);

        mCTUT.updateVtDataUsage(call, 70);

        mCTUT.updateVtDataUsage(call, 91);

        verify(mVtDataUsageProviderCb, never()).onStatsUpdated(anyInt(), any(), any());



        // Verify that diff stats from last update is reported accordingly.

        provider.requestStatsUpdate(13);

        // Rounding error occurs so (70-51)/2 + (91-70)/2 = 19 is expected for both direction.

        assertVtDataUsageUpdated(13, 19, 19);

    }



    private void assertVtDataUsageUpdated(int expectedToken, long rxBytes, long txBytes) {

        final ArgumentCaptor<NetworkStats> ifaceStatsCaptor = ArgumentCaptor.forClass(

                NetworkStats.class);

        final ArgumentCaptor<NetworkStats> uidStatsCaptor = ArgumentCaptor.forClass(

                NetworkStats.class);



        verify(mVtDataUsageProviderCb).onStatsUpdated(eq(expectedToken), ifaceStatsCaptor.capture(),

                uidStatsCaptor.capture());



        // Default dialer's package uid is not set during test, thus the uid stats looks the same

        // as iface stats and the records are always merged into the same entry.

        // TODO: Mock different dialer's uid and verify uid stats has corresponding uid in the

        //  records.

        NetworkStats expectedStats = new NetworkStats(0L, 0);



        if (rxBytes != 0 || txBytes != 0) {

            expectedStats = expectedStats.addValues(

                    new Entry(NetworkStats.IFACE_VT, UID_ALL, SET_FOREGROUND,

                            TAG_NONE, METERED_YES, ROAMING_NO, DEFAULT_NETWORK_YES, rxBytes, 0L,

                            txBytes, 0L, 0L));

        }

        assertNetworkStatsEquals(expectedStats, ifaceStatsCaptor.getValue());

        assertNetworkStatsEquals(expectedStats, uidStatsCaptor.getValue());

    }



    private ImsPhoneConnection placeCallAndMakeActive() {

        try {

            doAnswer(new Answer<ImsCall>() {