Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b872941b authored by Amit Mahajan's avatar Amit Mahajan
Browse files

Removing OrSelf check when checking for PRIVILEGED_PHONE_STATE perm. 

Self check is done as part of READ_PHONE_STATE and AppOps checks.

Bug: 22376654
Change-Id: I437f9bf324950cb70bae5be76699824da5897a6f
parent b1103de1

src/java/com/android/internal/telephony/PhoneSubInfo.java

+2 −2
Original line number Diff line number Diff line
@@ -367,10 +367,10 @@ public class PhoneSubInfo { 


    private boolean checkReadPhoneState(String callingPackage, String message) {

        try {

            mContext.enforceCallingOrSelfPermission(

            mContext.enforceCallingPermission(

                    android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE, message);



            // SKIP checking run-time OP_READ_PHONE_STATE since self or using PRIVILEGED

            // SKIP checking run-time OP_READ_PHONE_STATE since using PRIVILEGED

            return true;

        } catch (SecurityException e) {

            mContext.enforceCallingOrSelfPermission(android.Manifest.permission.READ_PHONE_STATE,

src/java/com/android/internal/telephony/SubscriptionController.java

+2 −2
Original line number Diff line number Diff line
@@ -208,10 +208,10 @@ public class SubscriptionController extends ISub.Stub { 
     */

    private boolean canReadPhoneState(String callingPackage, String message) {

        try {

            mContext.enforceCallingOrSelfPermission(

            mContext.enforceCallingPermission(

                    android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE, message);



            // SKIP checking run-time permission since self or using PRIVILEDGED permission

            // SKIP checking run-time permission since using PRIVILEDGED permission

            return true;

        } catch (SecurityException e) {

            mContext.enforceCallingOrSelfPermission(android.Manifest.permission.READ_PHONE_STATE,