Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a438d8df authored by Rambo Wang's avatar Rambo Wang Committed by Automerger Merge Worker
Browse files

Merge "Always call unbindService no matter what bindService returns" am:... 

Merge "Always call unbindService no matter what bindService returns" am: b0a32912 am: 220b1056 am: edcb2dd7

Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/telephony/+/1854666

Change-Id: I755f78956f794dc6001faae9e611efe7a9c375c8
parents 41efd876 edcb2dd7

src/java/com/android/internal/telephony/CarrierServiceBindHelper.java

+5 −12
Original line number Diff line number Diff line
@@ -71,9 +71,6 @@ public class CarrierServiceBindHelper { 
    private final PackageChangeReceiver mPackageMonitor = new CarrierServicePackageMonitor();

    private final LocalLog mLocalLog = new LocalLog(100);



    // whether we have successfully bound to the service

    private boolean mServiceBound = false;



    private BroadcastReceiver mUserUnlockedReceiver = new BroadcastReceiver() {

        @Override

        public void onReceive(Context context, Intent intent) {
@@ -291,7 +288,6 @@ public class CarrierServiceBindHelper { 
                        (r) -> mHandler.post(r),

                        connection)) {

                    logdWithLocalLog("service bound");

                    mServiceBound = true;

                    return;

                }
@@ -346,17 +342,14 @@ public class CarrierServiceBindHelper { 
            carrierPackage = null;

            carrierServiceClass = null;



            // Actually unbind

            if (mServiceBound) {

                logdWithLocalLog("Unbinding from carrier app");

                mServiceBound = false;

            // Always call unbindService, no matter if bindService succeed.

            if (connection != null) {

                mContext.unbindService(connection);

            } else {

                logdWithLocalLog("Not bound, skipping unbindService call");

            }

                logdWithLocalLog("Unbinding from carrier app");

                connection = null;

                mUnbindScheduledUptimeMillis = -1;

            }

        }



        private void cancelScheduledUnbind() {

            logdWithLocalLog("cancelScheduledUnbind");