Merge "Get rid of SIM record access in DcTracker" am: 6dbb75fd9e (9b617ef2) · Commits · e / os / android_frameworks_opt_telephony

src/java/com/android/internal/telephony/GsmCdmaPhone.java

+6 −7

Original line number	Diff line number	Diff line
		@@ -91,6 +91,7 @@ import com.android.internal.telephony.dataconnection.TransportManager;
		import com.android.internal.telephony.emergency.EmergencyNumberTracker;
		import com.android.internal.telephony.gsm.GsmMmiCode;
		import com.android.internal.telephony.gsm.SuppServiceNotification;
		import com.android.internal.telephony.imsphone.ImsPhoneMmiCode;
		import com.android.internal.telephony.test.SimulatedRadioControl;
		import com.android.internal.telephony.uicc.IccCardApplicationStatus.AppType;
		import com.android.internal.telephony.uicc.IccCardStatus;
		@@ -109,7 +110,6 @@ import com.android.internal.telephony.uicc.UiccProfile;
		import com.android.internal.telephony.uicc.UiccSlot;
		import com.android.internal.telephony.util.ArrayUtils;
		import com.android.telephony.Rlog;
		import com.android.internal.telephony.imsphone.ImsPhoneMmiCode;

		import java.io.FileDescriptor;
		import java.io.PrintWriter;
		@@ -3159,7 +3159,7 @@ public class GsmCdmaPhone extends Phone {
		simOperatorNumeric);
		}
		}
		updateDataConnectionTracker();
		updateCurrentCarrierInProvider();
		}
		}

		@@ -4029,10 +4029,9 @@ public class GsmCdmaPhone extends Phone {
		return dialString;
		}

		/**
		* @return operator numeric.
		*/
		private String getOperatorNumeric() {
		@Override
		@NonNull
		public String getOperatorNumeric() {
		String operatorNumeric = null;
		if (isPhoneTypeGsm()) {
		IccRecords r = mIccRecords.get();
		@@ -4074,7 +4073,7 @@ public class GsmCdmaPhone extends Phone {
		+ " operatorNumeric = " + operatorNumeric);

		}
		return operatorNumeric;
		return TextUtils.emptyIfNull(operatorNumeric);
		}

		/**

src/java/com/android/internal/telephony/Phone.java

+10 −10

Original line number	Diff line number	Diff line
		@@ -4044,16 +4044,6 @@ public abstract class Phone extends Handler implements PhoneInternalInterface {
		return getLocaleFromCarrierProperties();
		}

		public void updateDataConnectionTracker() {
		if (mTransportManager != null) {
		for (int transport : mTransportManager.getAvailableTransports()) {
		if (getDcTracker(transport) != null) {
		getDcTracker(transport).update();
		}
		}
		}
		}

		public boolean updateCurrentCarrierInProvider() {
		return false;
		}
		@@ -4257,6 +4247,16 @@ public abstract class Phone extends Handler implements PhoneInternalInterface {
		return false;
		}

		/**
		* Get the SIM's MCC/MNC
		*
		* @return MCC/MNC in string format, empty string if not available.
		*/
		@NonNull
		public String getOperatorNumeric() {
		return "";
		}

		public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
		pw.println("Phone: subId=" + getSubId());
		pw.println(" mPhoneId=" + mPhoneId);

src/java/com/android/internal/telephony/SubscriptionController.java

+0 −17

Original line number	Diff line number	Diff line
		@@ -1247,9 +1247,6 @@ public class SubscriptionController extends ISub.Stub {
		if (DBG) logdl("[addSubInfoRecord] sim name = " + nameToSet);
		}

		// Once the records are loaded, notify DcTracker
		PhoneFactory.getPhone(slotIndex).updateDataConnectionTracker();

		if (DBG) logdl("[addSubInfoRecord]- info size=" + sSlotIndexToSubIds.size());
		}

		@@ -2361,9 +2358,6 @@ public class SubscriptionController extends ISub.Stub {
		}
		}

		// FIXME is this still needed?
		updateAllDataConnectionTrackers();

		int previousDefaultSub = getDefaultSubId();
		Settings.Global.putInt(mContext.getContentResolver(),
		Settings.Global.MULTI_SIM_DATA_CALL_SUBSCRIPTION, subId);
		@@ -2377,17 +2371,6 @@ public class SubscriptionController extends ISub.Stub {
		}
		}

		@UnsupportedAppUsage
		private void updateAllDataConnectionTrackers() {
		// Tell Phone Proxies to update data connection tracker
		int len = TelephonyManager.from(mContext).getActiveModemCount();
		if (DBG) logd("[updateAllDataConnectionTrackers] activeModemCount=" + len);
		for (int phoneId = 0; phoneId < len; phoneId++) {
		if (DBG) logd("[updateAllDataConnectionTrackers] phoneId=" + phoneId);
		PhoneFactory.getPhone(phoneId).updateDataConnectionTracker();
		}
		}

		@UnsupportedAppUsage
		private void broadcastDefaultDataSubIdChanged(int subId) {
		// Broadcast an Intent for default data sub change

src/java/com/android/internal/telephony/dataconnection/DataConnectionReasons.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -106,7 +106,7 @@ public class DataConnectionReasons {

		// Belows are all hard failure reasons.
		NOT_ATTACHED(true),
		RECORD_NOT_LOADED(true),
		SIM_NOT_READY(true),
		INVALID_PHONE_STATE(true),
		CONCURRENT_VOICE_DATA_NOT_ALLOWED(true),
		PS_RESTRICTED(true),

src/java/com/android/internal/telephony/dataconnection/DcTracker.java

+89 −178

File changed.

Preview size limit exceeded, changes collapsed.