Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93d21eb6 authored by Jack Yu's avatar Jack Yu Committed by Daniel Bright
Browse files

Renamed retry interval to retry duration 

Fix: 171981823
Test: FrameworksTelephonyTests
Merged-In: Ibb1332d85a0518c96ba8fd01b24b2699c915c89d
Change-Id: Ibb1332d85a0518c96ba8fd01b24b2699c915c89d
parent 2037f906

src/java/com/android/internal/telephony/RIL.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -7502,7 +7502,7 @@ public class RIL extends BaseCommands implements CommandsInterface { 




        return new DataCallResponse.Builder()

        return new DataCallResponse.Builder()

                .setCause(cause)

                .setCause(cause)

                .setRetryIntervalMillis(suggestedRetryTime)

                .setRetryDurationMillis(suggestedRetryTime)

                .setId(cid)

                .setId(cid)

                .setLinkStatus(active)

                .setLinkStatus(active)

                .setProtocolType(protocolType)

                .setProtocolType(protocolType)

src/java/com/android/internal/telephony/RetryManager.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -130,7 +130,7 @@ public class RetryManager { 
    /**

    /**

     * The value indicating network did not suggest any retry delay

     * The value indicating network did not suggest any retry delay

     */

     */

    public static final long NO_SUGGESTED_RETRY_DELAY = DataCallResponse.RETRY_INTERVAL_UNDEFINED;

    public static final long NO_SUGGESTED_RETRY_DELAY = DataCallResponse.RETRY_DURATION_UNDEFINED;





    /**

    /**

     * If the network suggests a retry delay in the data call setup response, we will retry

     * If the network suggests a retry delay in the data call setup response, we will retry

src/java/com/android/internal/telephony/dataconnection/DataConnection.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -747,7 +747,7 @@ public class DataConnection extends StateMachine { 
        if (mDcTesterFailBringUpAll.getDcFailBringUp().mCounter  > 0) {

        if (mDcTesterFailBringUpAll.getDcFailBringUp().mCounter  > 0) {

            DataCallResponse response = new DataCallResponse.Builder()

            DataCallResponse response = new DataCallResponse.Builder()

                    .setCause(mDcTesterFailBringUpAll.getDcFailBringUp().mFailCause)

                    .setCause(mDcTesterFailBringUpAll.getDcFailBringUp().mFailCause)

                    .setRetryIntervalMillis(

                    .setRetryDurationMillis(

                            mDcTesterFailBringUpAll.getDcFailBringUp().mSuggestedRetryTime)

                            mDcTesterFailBringUpAll.getDcFailBringUp().mSuggestedRetryTime)

                    .setMtuV4(PhoneConstants.UNSET_MTU)

                    .setMtuV4(PhoneConstants.UNSET_MTU)

                    .setMtuV6(PhoneConstants.UNSET_MTU)

                    .setMtuV6(PhoneConstants.UNSET_MTU)
@@ -3122,7 +3122,7 @@ public class DataConnection extends StateMachine { 
         * The value of Long.MAX_VALUE(0x7fffffffffffffff) means no retry.

         * The value of Long.MAX_VALUE(0x7fffffffffffffff) means no retry.

         */

         */





        long suggestedRetryTime = response.getRetryIntervalMillis();

        long suggestedRetryTime = response.getRetryDurationMillis();





        // The value < 0 means no value is suggested

        // The value < 0 means no value is suggested

        if (suggestedRetryTime < 0) {

        if (suggestedRetryTime < 0) {

tests/telephonytests/src/com/android/internal/telephony/RILTest.java

+2 −2
Original line number Original line Diff line number Diff line
@@ -2161,7 +2161,7 @@ public class RILTest extends TelephonyTest { 




        DataCallResponse response = new DataCallResponse.Builder()

        DataCallResponse response = new DataCallResponse.Builder()

                .setCause(0)

                .setCause(0)

                .setRetryIntervalMillis(-1L)

                .setRetryDurationMillis(-1L)

                .setId(0)

                .setId(0)

                .setLinkStatus(2)

                .setLinkStatus(2)

                .setProtocolType(ApnSetting.PROTOCOL_IPV4V6)

                .setProtocolType(ApnSetting.PROTOCOL_IPV4V6)
@@ -2235,7 +2235,7 @@ public class RILTest extends TelephonyTest { 




        response = new DataCallResponse.Builder()

        response = new DataCallResponse.Builder()

                .setCause(0)

                .setCause(0)

                .setRetryIntervalMillis(-1L)

                .setRetryDurationMillis(-1L)

                .setId(0)

                .setId(0)

                .setLinkStatus(2)

                .setLinkStatus(2)

                .setProtocolType(ApnSetting.PROTOCOL_IPV4V6)

                .setProtocolType(ApnSetting.PROTOCOL_IPV4V6)

tests/telephonytests/src/com/android/internal/telephony/dataconnection/DataCallResponseTest.java

+4 −4
Original line number Original line Diff line number Diff line
@@ -40,7 +40,7 @@ public class DataCallResponseTest extends AndroidTestCase { 
    public void testParcel() throws Exception {

    public void testParcel() throws Exception {

        DataCallResponse response = new DataCallResponse.Builder()

        DataCallResponse response = new DataCallResponse.Builder()

                .setCause(0)

                .setCause(0)

                .setRetryIntervalMillis(-1L)

                .setRetryDurationMillis(-1L)

                .setId(1)

                .setId(1)

                .setLinkStatus(2)

                .setLinkStatus(2)

                .setProtocolType(ApnSetting.PROTOCOL_IP)

                .setProtocolType(ApnSetting.PROTOCOL_IP)
@@ -69,7 +69,7 @@ public class DataCallResponseTest extends AndroidTestCase { 
    public void testEquals() throws Exception {

    public void testEquals() throws Exception {

        DataCallResponse response = new DataCallResponse.Builder()

        DataCallResponse response = new DataCallResponse.Builder()

                .setCause(0)

                .setCause(0)

                .setRetryIntervalMillis(-1L)

                .setRetryDurationMillis(-1L)

                .setId(1)

                .setId(1)

                .setLinkStatus(2)

                .setLinkStatus(2)

                .setProtocolType(ApnSetting.PROTOCOL_IP)

                .setProtocolType(ApnSetting.PROTOCOL_IP)
@@ -86,7 +86,7 @@ public class DataCallResponseTest extends AndroidTestCase { 




        DataCallResponse response1 = new DataCallResponse.Builder()

        DataCallResponse response1 = new DataCallResponse.Builder()

                .setCause(0)

                .setCause(0)

                .setRetryIntervalMillis(-1L)

                .setRetryDurationMillis(-1L)

                .setId(1)

                .setId(1)

                .setLinkStatus(2)

                .setLinkStatus(2)

                .setProtocolType(ApnSetting.PROTOCOL_IP)

                .setProtocolType(ApnSetting.PROTOCOL_IP)
@@ -106,7 +106,7 @@ public class DataCallResponseTest extends AndroidTestCase { 




        DataCallResponse response2 = new DataCallResponse.Builder()

        DataCallResponse response2 = new DataCallResponse.Builder()

                .setCause(1)

                .setCause(1)

                .setRetryIntervalMillis(-1L)

                .setRetryDurationMillis(-1L)

                .setId(1)

                .setId(1)

                .setLinkStatus(3)

                .setLinkStatus(3)

                .setProtocolType(ApnSetting.PROTOCOL_IP)

                .setProtocolType(ApnSetting.PROTOCOL_IP)