Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90c23da1 authored by Malcolm Chen's avatar Malcolm Chen
Browse files

Move ACTION_CARRIER_* intent and extras from TelephonyIntents to 

TelephonyManager.

The purpose is to expose them as @SystemApi as they are used externally.

Bug: 140908357
Test: unittest
Change-Id: Ie74f20a7e6a47a4c478acfdb02634bc735aa2edb
parent dd5f32fe

src/java/com/android/internal/telephony/CarrierActionAgent.java

+1 −1
Original line number Diff line number Diff line
@@ -227,7 +227,7 @@ public class CarrierActionAgent extends Handler { 
        carrierActionSetRadioEnabled(true);

        // notify configured carrier apps for reset

        mPhone.getCarrierSignalAgent().notifyCarrierSignalReceivers(

                new Intent(TelephonyIntents.ACTION_CARRIER_SIGNAL_RESET));

                new Intent(TelephonyManager.ACTION_CARRIER_SIGNAL_RESET));

    }



    private RegistrantList getRegistrantsFromAction(int action) {

src/java/com/android/internal/telephony/CarrierSignalAgent.java

+13 −12
Original line number Diff line number Diff line
@@ -15,6 +15,9 @@ 
 */

package com.android.internal.telephony;



import static android.telephony.CarrierConfigManager.KEY_CARRIER_APP_NO_WAKE_SIGNAL_CONFIG_STRING_ARRAY;

import static android.telephony.CarrierConfigManager.KEY_CARRIER_APP_WAKE_SIGNAL_CONFIG_STRING_ARRAY;



import android.content.ActivityNotFoundException;

import android.content.BroadcastReceiver;

import android.content.ComponentName;
@@ -32,6 +35,7 @@ import android.os.UserHandle; 
import android.telephony.CarrierConfigManager;

import android.telephony.Rlog;

import android.telephony.SubscriptionManager;

import android.telephony.TelephonyManager;

import android.text.TextUtils;

import android.util.LocalLog;

import android.util.Log;
@@ -47,9 +51,6 @@ import java.util.HashSet; 
import java.util.Map;

import java.util.Set;



import static android.telephony.CarrierConfigManager.KEY_CARRIER_APP_WAKE_SIGNAL_CONFIG_STRING_ARRAY;

import static android.telephony.CarrierConfigManager.KEY_CARRIER_APP_NO_WAKE_SIGNAL_CONFIG_STRING_ARRAY;



/**

 * This class act as an CarrierSignalling Agent.

 * it load registered carrier signalling receivers from carrier config, cache the result to avoid
@@ -98,11 +99,11 @@ public class CarrierSignalAgent extends Handler { 
     * This is a list of supported signals from CarrierSignalAgent

     */

    private final Set<String> mCarrierSignalList = new HashSet<>(Arrays.asList(

            TelephonyIntents.ACTION_CARRIER_SIGNAL_PCO_VALUE,

            TelephonyIntents.ACTION_CARRIER_SIGNAL_REDIRECTED,

            TelephonyIntents.ACTION_CARRIER_SIGNAL_REQUEST_NETWORK_FAILED,

            TelephonyIntents.ACTION_CARRIER_SIGNAL_RESET,

            TelephonyIntents.ACTION_CARRIER_SIGNAL_DEFAULT_NETWORK_AVAILABLE));

            TelephonyManager.ACTION_CARRIER_SIGNAL_PCO_VALUE,

            TelephonyManager.ACTION_CARRIER_SIGNAL_REDIRECTED,

            TelephonyManager.ACTION_CARRIER_SIGNAL_REQUEST_NETWORK_FAILED,

            TelephonyManager.ACTION_CARRIER_SIGNAL_RESET,

            TelephonyManager.ACTION_CARRIER_SIGNAL_DEFAULT_NETWORK_AVAILABLE));



    private final LocalLog mErrorLocalLog = new LocalLog(20);
@@ -148,10 +149,10 @@ public class CarrierSignalAgent extends Handler { 
                            // an optimization to avoid signaling on every default network switch.

                            if (!mDefaultNetworkAvail) {

                                if (DBG) log("Default network available: " + network);

                                Intent intent = new Intent(TelephonyIntents

                                Intent intent = new Intent(TelephonyManager

                                        .ACTION_CARRIER_SIGNAL_DEFAULT_NETWORK_AVAILABLE);

                                intent.putExtra(

                                        TelephonyIntents.EXTRA_DEFAULT_NETWORK_AVAILABLE_KEY, true);

                                        TelephonyManager.EXTRA_DEFAULT_NETWORK_AVAILABLE, true);

                                notifyCarrierSignalReceivers(intent);

                                mDefaultNetworkAvail = true;

                            }
@@ -159,10 +160,10 @@ public class CarrierSignalAgent extends Handler { 
                        @Override

                        public void onLost(Network network) {

                            if (DBG) log("Default network lost: " + network);

                            Intent intent = new Intent(TelephonyIntents

                            Intent intent = new Intent(TelephonyManager

                                    .ACTION_CARRIER_SIGNAL_DEFAULT_NETWORK_AVAILABLE);

                            intent.putExtra(

                                    TelephonyIntents.EXTRA_DEFAULT_NETWORK_AVAILABLE_KEY, false);

                                    TelephonyManager.EXTRA_DEFAULT_NETWORK_AVAILABLE, false);

                            notifyCarrierSignalReceivers(intent);

                            mDefaultNetworkAvail = false;

                        }

src/java/com/android/internal/telephony/dataconnection/DataConnection.java

+1 −2
Original line number Diff line number Diff line
@@ -76,7 +76,6 @@ import com.android.internal.telephony.PhoneFactory; 
import com.android.internal.telephony.RILConstants;

import com.android.internal.telephony.RetryManager;

import com.android.internal.telephony.ServiceStateTracker;

import com.android.internal.telephony.TelephonyIntents;

import com.android.internal.telephony.dataconnection.DcTracker.ReleaseNetworkType;

import com.android.internal.telephony.dataconnection.DcTracker.RequestNetworkType;

import com.android.internal.telephony.metrics.TelephonyMetrics;
@@ -2046,7 +2045,7 @@ public class DataConnection extends StateMachine { 


            final NetworkMisc misc = new NetworkMisc();

            final CarrierSignalAgent carrierSignalAgent = mPhone.getCarrierSignalAgent();

            if (carrierSignalAgent.hasRegisteredReceivers(TelephonyIntents

            if (carrierSignalAgent.hasRegisteredReceivers(TelephonyManager

                    .ACTION_CARRIER_SIGNAL_REDIRECTED)) {

                // carrierSignal Receivers will place the carrier-specific provisioning notification

                misc.provisioningNotificationDisabled = true;

src/java/com/android/internal/telephony/dataconnection/DcTracker.java

+25 −16
Original line number Diff line number Diff line
@@ -19,6 +19,8 @@ package com.android.internal.telephony.dataconnection; 
import static android.Manifest.permission.READ_PRIVILEGED_PHONE_STATE;

import static android.telephony.TelephonyManager.NETWORK_TYPE_LTE;

import static android.telephony.TelephonyManager.NETWORK_TYPE_NR;

import static android.telephony.data.ApnSetting.PROTOCOL_IPV4V6;

import static android.telephony.data.ApnSetting.TYPE_DEFAULT;



import static com.android.internal.telephony.RILConstants.DATA_PROFILE_DEFAULT;

import static com.android.internal.telephony.RILConstants.DATA_PROFILE_INVALID;
@@ -105,7 +107,6 @@ import com.android.internal.telephony.PhoneFactory; 
import com.android.internal.telephony.PhoneSwitcher;

import com.android.internal.telephony.RILConstants;

import com.android.internal.telephony.SettingsObserver;

import com.android.internal.telephony.TelephonyIntents;

import com.android.internal.telephony.dataconnection.DataConnectionReasons.DataAllowedReasonType;

import com.android.internal.telephony.dataconnection.DataConnectionReasons.DataDisallowedReasonType;

import com.android.internal.telephony.dataconnection.DataEnabledSettings.DataEnabledChangedReason;
@@ -2859,11 +2860,13 @@ public class DcTracker extends Handler { 
                        final byte[] value = new byte[1];

                        value[0] = (byte) pcoVal;

                        final Intent intent =

                                new Intent(TelephonyIntents.ACTION_CARRIER_SIGNAL_PCO_VALUE);

                        intent.putExtra(TelephonyIntents.EXTRA_APN_TYPE_KEY, "default");

                        intent.putExtra(TelephonyIntents.EXTRA_APN_PROTO_KEY, "IPV4V6");

                        intent.putExtra(TelephonyIntents.EXTRA_PCO_ID_KEY, 0xFF00);

                        intent.putExtra(TelephonyIntents.EXTRA_PCO_VALUE_KEY, value);

                                new Intent(TelephonyManager.ACTION_CARRIER_SIGNAL_PCO_VALUE);

                        intent.putExtra(TelephonyManager.EXTRA_APN_TYPE, "default");

                        intent.putExtra(TelephonyManager.EXTRA_APN_TYPE_INT, TYPE_DEFAULT);

                        intent.putExtra(TelephonyManager.EXTRA_APN_PROTOCOL, "IPV4V6");

                        intent.putExtra(TelephonyManager.EXTRA_APN_PROTOCOL_INT, PROTOCOL_IPV4V6);

                        intent.putExtra(TelephonyManager.EXTRA_PCO_ID, 0xFF00);

                        intent.putExtra(TelephonyManager.EXTRA_PCO_VALUE, value);

                        mPhone.getCarrierSignalAgent().notifyCarrierSignalReceivers(intent);

                    }

                }
@@ -2885,10 +2888,12 @@ public class DcTracker extends Handler { 
                    apn != null ? apn.getApnName() : null, cause);



            // Compose broadcast intent send to the specific carrier signaling receivers

            Intent intent = new Intent(TelephonyIntents

            Intent intent = new Intent(TelephonyManager

                    .ACTION_CARRIER_SIGNAL_REQUEST_NETWORK_FAILED);

            intent.putExtra(TelephonyIntents.EXTRA_ERROR_CODE_KEY, cause);

            intent.putExtra(TelephonyIntents.EXTRA_APN_TYPE_KEY, apnContext.getApnType());

            intent.putExtra(TelephonyManager.EXTRA_ERROR_CODE, cause);

            intent.putExtra(TelephonyManager.EXTRA_APN_TYPE, apnContext.getApnType());

            intent.putExtra(TelephonyManager.EXTRA_APN_TYPE_INT,

                    ApnSetting.getApnTypesBitmaskFromString(apnContext.getApnType()));

            mPhone.getCarrierSignalAgent().notifyCarrierSignalReceivers(intent);



            if (DataFailCause.isRadioRestartFailure(mPhone.getContext(), cause, mPhone.getSubId())
@@ -2948,8 +2953,8 @@ public class DcTracker extends Handler { 
     */

    private void onNetworkStatusChanged(int status, int cid, String redirectUrl) {

        if (!TextUtils.isEmpty(redirectUrl)) {

            Intent intent = new Intent(TelephonyIntents.ACTION_CARRIER_SIGNAL_REDIRECTED);

            intent.putExtra(TelephonyIntents.EXTRA_REDIRECTION_URL_KEY, redirectUrl);

            Intent intent = new Intent(TelephonyManager.ACTION_CARRIER_SIGNAL_REDIRECTED);

            intent.putExtra(TelephonyManager.EXTRA_REDIRECTION_URL, redirectUrl);

            mPhone.getCarrierSignalAgent().notifyCarrierSignalReceivers(intent);

            log("Notify carrier signal receivers with redirectUrl: " + redirectUrl);

        } else {
@@ -4514,11 +4519,15 @@ public class DcTracker extends Handler { 
            for (ApnContext apnContext : apnContextList) {

                String apnType = apnContext.getApnType();



                final Intent intent = new Intent(TelephonyIntents.ACTION_CARRIER_SIGNAL_PCO_VALUE);

                intent.putExtra(TelephonyIntents.EXTRA_APN_TYPE_KEY, apnType);

                intent.putExtra(TelephonyIntents.EXTRA_APN_PROTO_KEY, pcoData.bearerProto);

                intent.putExtra(TelephonyIntents.EXTRA_PCO_ID_KEY, pcoData.pcoId);

                intent.putExtra(TelephonyIntents.EXTRA_PCO_VALUE_KEY, pcoData.contents);

                final Intent intent = new Intent(TelephonyManager.ACTION_CARRIER_SIGNAL_PCO_VALUE);

                intent.putExtra(TelephonyManager.EXTRA_APN_TYPE, apnType);

                intent.putExtra(TelephonyManager.EXTRA_APN_TYPE_INT,

                        ApnSetting.getApnTypesBitmaskFromString(apnType));

                intent.putExtra(TelephonyManager.EXTRA_APN_PROTOCOL, pcoData.bearerProto);

                intent.putExtra(TelephonyManager.EXTRA_APN_PROTOCOL_INT,

                        ApnSetting.getProtocolIntFromString(pcoData.bearerProto));

                intent.putExtra(TelephonyManager.EXTRA_PCO_ID, pcoData.pcoId);

                intent.putExtra(TelephonyManager.EXTRA_PCO_VALUE, pcoData.contents);

                mPhone.getCarrierSignalAgent().notifyCarrierSignalReceivers(intent);

            }

        }

tests/telephonytests/src/com/android/internal/telephony/CarrierSignalAgentTest.java

+2 −3
Original line number Diff line number Diff line
@@ -15,9 +15,8 @@ 
 */

package com.android.internal.telephony;



import static com.android.internal.telephony.TelephonyIntents.ACTION_CARRIER_SIGNAL_PCO_VALUE;

import static com.android.internal.telephony.TelephonyIntents

        .ACTION_CARRIER_SIGNAL_REQUEST_NETWORK_FAILED;

import static android.telephony.TelephonyManager.ACTION_CARRIER_SIGNAL_PCO_VALUE;

import static android.telephony.TelephonyManager.ACTION_CARRIER_SIGNAL_REQUEST_NETWORK_FAILED;



import static org.junit.Assert.assertEquals;

import static org.mockito.ArgumentMatchers.anyLong;