Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fee6bae authored by Yoshiaki Naka's avatar Yoshiaki Naka
Browse files

Text string TLV object shall not be output in log 

The text string TLV object shall be hidden in the log as it might
contain personal information like password input by user. The issue was
fixed once before, but additional change is required due to the change
in IccUtils which treats alphabet characters in upper-case now.

Bug: 118646057
Test: Confirmed that the text string is not output in the radio log.

Change-Id: Ib93355c9b58514897c264600db73f5ddd7f41594
parent 69fcd032

src/java/com/android/internal/telephony/RIL.java

+1 −1
Original line number Diff line number Diff line
@@ -2344,7 +2344,7 @@ public class RIL extends BaseCommands implements CommandsInterface { 
                        byte[] target = Arrays.copyOfRange(ctlv.getRawValue(), from,

                                ctlv.getValueIndex() + ctlv.getLength());

                        terminalResponse = terminalResponse.toLowerCase().replace(

                                IccUtils.bytesToHexString(target), "********");

                                IccUtils.bytesToHexString(target).toLowerCase(), "********");

                    }

                    // The text string tag and the length field should also be hidden.

                    from = ctlv.getValueIndex() + ctlv.getLength();