Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 631bddd4 authored by Nathan Harold's avatar Nathan Harold Committed by Gerrit Code Review
Browse files

Merge changes I8ba4ea97,I444a27c4 

* changes:
  Update Conditions for SignalStrength Unsols
  Add radio state condition for high power indications
parents 293c6b3e 4dd590c6

src/java/com/android/internal/telephony/DeviceStateMonitor.java

+44 −8
Original line number Diff line number Diff line
@@ -80,6 +80,8 @@ public class DeviceStateMonitor extends Handler { 
    @VisibleForTesting

    static final int EVENT_WIFI_CONNECTION_CHANGED      = 7;

    static final int EVENT_UPDATE_ALWAYS_REPORT_SIGNAL_STRENGTH = 8;

    static final int EVENT_RADIO_ON                     = 9;

    static final int EVENT_RADIO_OFF_OR_NOT_AVAILABLE   = 10;



    private static final int WIFI_UNAVAILABLE = 0;

    private static final int WIFI_AVAILABLE = 1;
@@ -177,6 +179,12 @@ public class DeviceStateMonitor extends Handler { 
     */

    private boolean mIsAutomotiveProjectionActive;



    /**

     * Radio is on. False means that radio is either off or not available and it is ok to reduce

     * commands to the radio to avoid unnecessary power consumption.

     */

    private boolean mIsRadioOn;



    /**

     * True indicates we should always enable the signal strength reporting from radio.

     */
@@ -269,6 +277,7 @@ public class DeviceStateMonitor extends Handler { 
        mIsPowerSaveOn = isPowerSaveModeOn();

        mIsCharging = isDeviceCharging();

        mIsScreenOn = isScreenOn();

        mIsRadioOn = isRadioOn();

        mIsAutomotiveProjectionActive = isAutomotiveProjectionActive();

        // Assuming tethering is always off after boot up.

        mIsTetheringOn = false;
@@ -282,7 +291,8 @@ public class DeviceStateMonitor extends Handler { 
                + ", mIsAutomotiveProjectionActive=" + mIsAutomotiveProjectionActive

                + ", mIsWifiConnected=" + mIsWifiConnected

                + ", mIsAlwaysSignalStrengthReportingEnabled="

                + mIsAlwaysSignalStrengthReportingEnabled, false);

                + mIsAlwaysSignalStrengthReportingEnabled

                + ", mIsRadioOn=" + mIsRadioOn, false);



        final IntentFilter filter = new IntentFilter();

        filter.addAction(PowerManager.ACTION_POWER_SAVE_MODE_CHANGED);
@@ -293,6 +303,8 @@ public class DeviceStateMonitor extends Handler { 


        mPhone.mCi.registerForRilConnected(this, EVENT_RIL_CONNECTED, null);

        mPhone.mCi.registerForAvailable(this, EVENT_RADIO_AVAILABLE, null);

        mPhone.mCi.registerForOn(this, EVENT_RADIO_ON, null);

        mPhone.mCi.registerForOffOrNotAvailable(this, EVENT_RADIO_OFF_OR_NOT_AVAILABLE, null);



        ConnectivityManager cm = (ConnectivityManager) phone.getContext().getSystemService(

                Context.CONNECTIVITY_SERVICE);
@@ -313,7 +325,7 @@ public class DeviceStateMonitor extends Handler { 
     * @return True if low data is expected

     */

    private boolean isLowDataExpected() {

        return !mIsCharging && !mIsTetheringOn && !mIsScreenOn;

        return (!mIsCharging && !mIsTetheringOn && !mIsScreenOn) || !mIsRadioOn;

    }



    /**
@@ -343,10 +355,13 @@ public class DeviceStateMonitor extends Handler { 
     */

    private boolean shouldEnableSignalStrengthReports() {

        // We should enable signal strength update if one of the following condition is true.

        // 1. The device is charging.

        // 2. When the screen is on.

        // 3. Any of system services is registrating to always listen to signal strength changes

        return mIsAlwaysSignalStrengthReportingEnabled || mIsCharging || mIsScreenOn;

        // 1. Whenever the conditions for high power usage are met.

        // 2. Any of system services is registrating to always listen to signal strength changes

        //    and the radio is on (if radio is off no indications should be sent regardless, but

        //    in the rare case that something registers/unregisters for always-on indications

        //    and the radio is off, we might as well ignore it).

        return shouldEnableHighPowerConsumptionIndications()

                || (mIsAlwaysSignalStrengthReportingEnabled && mIsRadioOn);

    }



    /**
@@ -397,12 +412,14 @@ public class DeviceStateMonitor extends Handler { 
     * @return True if the response update should be enabled.

     */

    public boolean shouldEnableHighPowerConsumptionIndications() {

        // We should enable indications reports if one of the following condition is true.

        // We should enable indications reports if radio is on and one of the following conditions

        // is true:

        // 1. The device is charging.

        // 2. When the screen is on.

        // 3. When the tethering is on.

        // 4. When automotive projection (Android Auto) is on.

        return mIsCharging || mIsScreenOn || mIsTetheringOn || mIsAutomotiveProjectionActive;

        return (mIsCharging || mIsScreenOn || mIsTetheringOn || mIsAutomotiveProjectionActive)

                && mIsRadioOn;

    }



    /**
@@ -453,6 +470,12 @@ public class DeviceStateMonitor extends Handler { 
            case EVENT_RADIO_AVAILABLE:

                onReset();

                break;

            case EVENT_RADIO_ON:

                onUpdateDeviceState(msg.what, /* state= */ true);

                break;

            case EVENT_RADIO_OFF_OR_NOT_AVAILABLE:

                onUpdateDeviceState(msg.what, /* state= */ false);

                break;

            case EVENT_SCREEN_STATE_CHANGED:

            case EVENT_POWER_SAVE_MODE_CHANGED:

            case EVENT_CHARGING_STATE_CHANGED:
@@ -488,6 +511,11 @@ public class DeviceStateMonitor extends Handler { 
                mIsCharging = state;

                sendDeviceState(CHARGING_STATE, mIsCharging);

                break;

            case EVENT_RADIO_ON:

            case EVENT_RADIO_OFF_OR_NOT_AVAILABLE:

                if (mIsRadioOn == state) return;

                mIsRadioOn = state;

                break;

            case EVENT_TETHERING_STATE_CHANGED:

                if (mIsTetheringOn == state) return;

                mIsTetheringOn = state;
@@ -706,6 +734,13 @@ public class DeviceStateMonitor extends Handler { 
        return false;

    }



    /**

     * @return True if the radio is on.

     */

    private boolean isRadioOn() {

        return mPhone.isRadioOn();

    }



    /**

     * @return True if automotive projection (Android Auto) is active.

     */
@@ -772,6 +807,7 @@ public class DeviceStateMonitor extends Handler { 
        ipw.println("mIsWifiConnected=" + mIsWifiConnected);

        ipw.println("mIsAlwaysSignalStrengthReportingEnabled="

                + mIsAlwaysSignalStrengthReportingEnabled);

        ipw.println("mIsRadioOn=" + mIsRadioOn);

        ipw.println("Local logs:");

        ipw.increaseIndent();

        mLocalLog.dump(fd, ipw, args);

tests/telephonytests/src/com/android/internal/telephony/DeviceStateMonitorTest.java

+81 −6
Original line number Diff line number Diff line
@@ -73,9 +73,7 @@ public class DeviceStateMonitorTest extends TelephonyTest { 
            | IndicationFilter.REGISTRATION_FAILURE

            | IndicationFilter.BARRING_INFO;



    // INDICATION_FILTERS_ALL but excludes Indication.SIGNAL_STRENGTH

    private static final int INDICATION_FILTERS_WHEN_TETHERING_ON =

            INDICATION_FILTERS_ALL & ~IndicationFilter.SIGNAL_STRENGTH;

    private static final int INDICATION_FILTERS_WHEN_TETHERING_ON = INDICATION_FILTERS_ALL;

    private static final int INDICATION_FILTERS_WHEN_CHARGING = INDICATION_FILTERS_ALL;

    private static final int INDICATION_FILTERS_WHEN_SCREEN_ON = INDICATION_FILTERS_ALL;
@@ -96,7 +94,6 @@ public class DeviceStateMonitorTest extends TelephonyTest { 
    // Keep the same value as corresponding event

    // See state2Event() for detail

    private static final int STATE_TYPE_RIL_CONNECTED = 0;

    // EVENT_UPDATE_NODE_CHANGED is not here, it will be removed in aosp soon

    private static final int STATE_TYPE_SCREEN = 2;

    private static final int STATE_TYPE_POWER_SAVE_MODE = 3;

    private static final int STATE_TYPE_CHARGING = 4;
@@ -104,6 +101,8 @@ public class DeviceStateMonitorTest extends TelephonyTest { 
    private static final int STATE_TYPE_RADIO_AVAILABLE = 6;

    private static final int STATE_TYPE_WIFI_CONNECTED = 7;

    private static final int STATE_TYPE_ALWAYS_SIGNAL_STRENGTH_REPORTED = 8;

    private static final int STATE_TYPE_RADIO_ON = 9;

    private static final int STATE_TYPE_RADIO_OFF_OR_NOT_AVAILABLE = 10;



    /** @hide */

    @IntDef(prefix = {"STATE_"}, value = {
@@ -236,19 +235,42 @@ public class DeviceStateMonitorTest extends TelephonyTest { 
    public void testScreenOnOff() {

        // screen was off by default, turn it on now

        updateState(STATE_TYPE_SCREEN, STATE_ON);

        processAllMessages();



        verify(mSimulatedCommandsVerifier).setUnsolResponseFilter(

                eq(INDICATION_FILTERS_WHEN_SCREEN_ON), nullable(Message.class));



        // turn screen off

        updateState(STATE_TYPE_SCREEN, STATE_OFF);

        processAllMessages();



        verify(mSimulatedCommandsVerifier).setUnsolResponseFilter(

                eq(INDICATION_FILTERS_MINIMUM), nullable(Message.class));

    }



    @Test

    public void testScreenOnOffwithRadioToggle() {

        // screen was off by default, turn it on now

        updateState(STATE_TYPE_SCREEN, STATE_ON);

        // turn off radio

        updateState(STATE_TYPE_RADIO_OFF_OR_NOT_AVAILABLE, /* stateValue is not used */ 0);



        verify(mSimulatedCommandsVerifier)

                .sendDeviceState(eq(LOW_DATA_EXPECTED), eq(true), nullable(Message.class));

        reset(mSimulatedCommandsVerifier);



        // turn screen off and on

        updateState(STATE_TYPE_SCREEN, STATE_OFF);

        updateState(STATE_TYPE_SCREEN, STATE_ON);



        verify(mSimulatedCommandsVerifier, never())

                .sendDeviceState(anyInt(), anyBoolean(), nullable(Message.class));



        // turn on radio

        updateState(STATE_TYPE_RADIO_ON, /* stateValue is not used */ 0);



        verify(mSimulatedCommandsVerifier)

                .sendDeviceState(eq(LOW_DATA_EXPECTED), eq(false), nullable(Message.class));

    }



    @Test

    public void testTethering() {

        // Turn tethering on
@@ -376,4 +398,57 @@ public class DeviceStateMonitorTest extends TelephonyTest { 
        updateState(STATE_TYPE_SCREEN, STATE_ON);

        verify(mSimulatedCommandsVerifier).getBarringInfo(nullable(Message.class));

    }



    @Test

    public void testGetBarringInfowithRadioToggle() {

        // screen was off by default, turn it on now

        updateState(STATE_TYPE_SCREEN, STATE_ON);



        verify(mSimulatedCommandsVerifier).getBarringInfo(nullable(Message.class));

        reset(mSimulatedCommandsVerifier);



        // turn off radio

        updateState(STATE_TYPE_RADIO_OFF_OR_NOT_AVAILABLE, /* stateValue is not used */ 0);



        verify(mSimulatedCommandsVerifier, never()).getBarringInfo(nullable(Message.class));



        // turn screen off and on

        updateState(STATE_TYPE_SCREEN, STATE_OFF);

        updateState(STATE_TYPE_SCREEN, STATE_ON);



        verify(mSimulatedCommandsVerifier, never()).getBarringInfo(nullable(Message.class));



        // turn on radio

        updateState(STATE_TYPE_RADIO_ON, /* stateValue is not used */ 0);



        verify(mSimulatedCommandsVerifier).getBarringInfo(nullable(Message.class));

    }



    @Test

    public void testAlwaysOnSignalStrengthwithRadioToggle() {

        // Start with the radio off

        updateState(STATE_TYPE_RADIO_OFF_OR_NOT_AVAILABLE, /* stateValue is not used */ 0);

        reset(mSimulatedCommandsVerifier);

        // Toggle always-reported signal strength while the radio is OFF. This should do nothing.

        // This should have no effect while the radio is off.

        updateState(STATE_TYPE_ALWAYS_SIGNAL_STRENGTH_REPORTED, STATE_ON);

        updateState(STATE_TYPE_ALWAYS_SIGNAL_STRENGTH_REPORTED, STATE_OFF);

        verify(mSimulatedCommandsVerifier, never())

                .sendDeviceState(anyInt(), anyBoolean(), nullable(Message.class));



        // Turn on the always reported signal strength and then the radio, which should just turn

        // on this one little thing more than the absolute minimum.

        updateState(STATE_TYPE_ALWAYS_SIGNAL_STRENGTH_REPORTED, STATE_ON);

        updateState(STATE_TYPE_RADIO_ON, /* stateValue is not used */ 0);

        verify(mSimulatedCommandsVerifier).setUnsolResponseFilter(

                eq(IndicationFilter.SIGNAL_STRENGTH | INDICATION_FILTERS_MINIMUM),

                        nullable(Message.class));



        // Turn off radio and see that SignalStrength goes off again. Technically, in this

        // direction, the value becomes a "don't-care", but it's not worth the complexity of having

        // the value only sync on the rising edge of radio power.

        updateState(STATE_TYPE_RADIO_OFF_OR_NOT_AVAILABLE, /* stateValue is not used */ 0);

        verify(mSimulatedCommandsVerifier).setUnsolResponseFilter(

                eq(INDICATION_FILTERS_MINIMUM), nullable(Message.class));

    }

}