Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6237f44d authored by Aishwarya Mallampati's avatar Aishwarya Mallampati
Browse files

Remove unnecessary synchronized(mLock) blocks. 

Bug: 409610090
Test: atest
Flag: com.android.internal.telephony.flags.satellite_improve_multi_thread_design
Change-Id: I655ed402d2653cde818d87a5095982c6bda9cebd
parent a5119916

src/java/com/android/internal/telephony/satellite/DatagramDispatcher.java

+32 −35
Original line number Diff line number Diff line
@@ -268,7 +268,6 @@ public class DatagramDispatcher extends Handler { 
                argument.setDatagramStartTime();

                onCompleted = obtainMessage(EVENT_SEND_SATELLITE_DATAGRAM_DONE, request);



                synchronized (mLock) {

                if (mIsDemoMode.get() && !shouldSendDatagramToModemInDemoMode()) {

                    AsyncResult.forMessage(onCompleted, SATELLITE_RESULT_SUCCESS, null);

                    sendMessageDelayed(onCompleted, getDemoTimeoutDuration());
@@ -279,7 +278,6 @@ public class DatagramDispatcher extends Handler { 
                            argument.needFullScreenPointingUI, onCompleted);

                    startWaitForDatagramSendingResponseTimer(argument);

                }

                }

                break;

            }

            case EVENT_SEND_SATELLITE_DATAGRAM_DONE: {
@@ -837,7 +835,6 @@ public class DatagramDispatcher extends Handler { 
    private void handleEventSatelliteModemStateChanged(

            @SatelliteManager.SatelliteModemState int state) {

        plogd("handleEventSatelliteModemStateChanged: state = " + state);

        synchronized (mLock) {

        mModemState.set(state);

        if (state == SatelliteManager.SATELLITE_MODEM_STATE_OFF

                || state == SatelliteManager.SATELLITE_MODEM_STATE_UNAVAILABLE) {
@@ -867,7 +864,7 @@ public class DatagramDispatcher extends Handler { 
                mShouldPollMtSms.set(shouldPollMtSms());

            }

        }

        }



        if (allowMtSmsPolling()) {

            sendMessage(obtainMessage(CMD_SEND_MT_SMS_POLLING_MESSAGE));

        }