Protect mIsRadioOn flag with a lock. (5c901f0e) · Commits · e / os / android_frameworks_opt_telephony

src/java/com/android/internal/telephony/satellite/SatelliteController.java

+24 −12

Original line number	Diff line number	Diff line
		@@ -317,6 +317,8 @@ public class SatelliteController extends Handler {
		private final Object mIsSatelliteEnabledLock = new Object();
		@GuardedBy("mIsSatelliteEnabledLock")
		private Boolean mIsSatelliteEnabled = null;
		private final Object mIsRadioOnLock = new Object();
		@GuardedBy("mIsRadioOnLock")
		private boolean mIsRadioOn = false;
		private final Object mSatelliteViaOemProvisionLock = new Object();
		@GuardedBy("mSatelliteViaOemProvisionLock")
		@@ -510,7 +512,10 @@ public class SatelliteController extends Handler {
		mContext, looper, mFeatureFlags, mPointingAppController);

		mCi.registerForRadioStateChanged(this, EVENT_RADIO_STATE_CHANGED, null);
		synchronized (mIsRadioOnLock) {
		mIsRadioOn = phone.isRadioOn();
		}

		registerForSatelliteProvisionStateChanged();
		registerForPendingDatagramCount();
		registerForSatelliteModemStateChanged();
		@@ -1213,12 +1218,14 @@ public class SatelliteController extends Handler {
		}

		case EVENT_RADIO_STATE_CHANGED: {
		synchronized (mIsRadioOnLock) {
		logd("EVENT_RADIO_STATE_CHANGED: radioState=" + mCi.getRadioState());
		if (mCi.getRadioState() == TelephonyManager.RADIO_POWER_ON) {
		mIsRadioOn = true;
		} else if (mCi.getRadioState() == TelephonyManager.RADIO_POWER_OFF) {
		mIsRadioOn = false;
		resetCarrierRoamingSatelliteModeParams();
		}
		}

		if (mCi.getRadioState() != TelephonyManager.RADIO_POWER_UNAVAILABLE) {
		if (mSatelliteModemInterface.isSatelliteServiceConnected()) {
		@@ -1493,12 +1500,14 @@ public class SatelliteController extends Handler {
		}

		if (enableSatellite) {
		synchronized (mIsRadioOnLock) {
		if (!mIsRadioOn) {
		ploge("Radio is not on, can not enable satellite");
		sendErrorAndReportSessionMetrics(
		SatelliteManager.SATELLITE_RESULT_INVALID_MODEM_STATE, result);
		return;
		}
		}
		} else {
		/* if disable satellite, always assume demo is also disabled */
		enableDemoMode = false;
		@@ -2639,12 +2648,15 @@ public class SatelliteController extends Handler {
		* modem. {@link SatelliteController} will then power off the satellite modem.
		*/
		public void onCellularRadioPowerOffRequested() {
		logd("onCellularRadioPowerOffRequested()");
		if (!mFeatureFlags.oemEnabledSatelliteFlag()) {
		plogd("onCellularRadioPowerOffRequested: oemEnabledSatelliteFlag is disabled");
		return;
		}

		synchronized (mIsRadioOnLock) {
		mIsRadioOn = false;
		}
		requestSatelliteEnabled(SubscriptionManager.DEFAULT_SUBSCRIPTION_ID,
		false /* enableSatellite /, false / enableDemoMode /, false / isEmergency */,
		new IIntegerConsumer.Stub() {