Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4f0c7206 authored by Malcolm Chen's avatar Malcolm Chen Committed by Xiangyu/Malcolm Chen
Browse files

Fix bug that we use the return value of bind service incorrectly. 

In the last CL, the negation operator "!" was mistakenly removed.
Adding it back.

Bug: 172607204
Test: manual. Send sms via carrier service and observe there's no
intermediate error message.

Change-Id: I45a5da7f759818d4e2e690e63127b8745634106a
Merged-In: I45a5da7f759818d4e2e690e63127b8745634106a
parent 78b82dfc

src/java/com/android/internal/telephony/SMSDispatcher.java

+2 −2
Original line number Diff line number Diff line
@@ -365,7 +365,7 @@ public abstract class SMSDispatcher extends Handler { 
        public void sendSmsByCarrierApp(String carrierPackageName,

                                        SmsSenderCallback senderCallback) {

            mSenderCallback = senderCallback;

            if (mCarrierMessagingServiceWrapper.bindToCarrierMessagingService(

            if (!mCarrierMessagingServiceWrapper.bindToCarrierMessagingService(

                    mContext, carrierPackageName, ()->onServiceReady())) {

                Rlog.e(TAG, "bindService() for carrier messaging service failed");

                mSenderCallback.onSendSmsComplete(
@@ -561,7 +561,7 @@ public abstract class SMSDispatcher extends Handler { 
        void sendSmsByCarrierApp(String carrierPackageName,

                                 MultipartSmsSenderCallback senderCallback) {

            mSenderCallback = senderCallback;

            if (mCarrierMessagingServiceWrapper.bindToCarrierMessagingService(

            if (!mCarrierMessagingServiceWrapper.bindToCarrierMessagingService(

                    mContext, carrierPackageName, ()->onServiceReady())) {

                Rlog.e(TAG, "bindService() for carrier messaging service failed");

                mSenderCallback.onSendMultipartSmsComplete(