Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4cda8ad7 authored by Ruchir Rastogi's avatar Ruchir Rastogi
Browse files

Move pullers to binder thread 

Pass direct executor to setPullAtomCallback. This cases the pullers to
run directly on the binder thread, as opposed to the background thread,
which could be busy with other work.

The move to the binder thread means that the pullers could execute
concurrently, but it looks like the pullers have already been made to be
thread-safe.

Test: m
Bug: 157186182
Change-Id: I1513ddb564f181a7c8810cd2e0c97db30e5ca7d5
parent dd284ae8

src/java/com/android/internal/telephony/metrics/MetricsCollector.java

+2 −2
Original line number Diff line number Diff line
@@ -31,11 +31,11 @@ import android.content.Context; 
import android.util.StatsEvent;



import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.os.BackgroundThread;

import com.android.internal.telephony.Phone;

import com.android.internal.telephony.PhoneFactory;

import com.android.internal.telephony.nano.PersistAtomsProto.RawVoiceCallRatUsage;

import com.android.internal.telephony.nano.PersistAtomsProto.VoiceCallSession;

import com.android.internal.util.ConcurrentUtils;

import com.android.telephony.Rlog;



import java.util.Arrays;
@@ -210,7 +210,7 @@ public class MetricsCollector implements StatsManager.StatsPullAtomCallback { 


    /** Registers a pulled atom ID {@code atomId} with optional {@code policy} for pulling. */

    private void registerAtom(int atomId, @Nullable StatsManager.PullAtomMetadata policy) {

        mStatsManager.setPullAtomCallback(atomId, policy, BackgroundThread.getExecutor(), this);

        mStatsManager.setPullAtomCallback(atomId, policy, ConcurrentUtils.DIRECT_EXECUTOR, this);

    }



    private static StatsEvent buildStatsEvent(RawVoiceCallRatUsage usage) {