Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48c8243a authored by Jordan Liu's avatar Jordan Liu Committed by Android (Google) Code Review
Browse files

Merge "Separate summary into DL and Ul"

parents 68139801 1cdd9598

proto/src/telephony.proto

+5 −2
Original line number Diff line number Diff line
@@ -2167,8 +2167,11 @@ message TelephonyCallSession { 
    // Call quality when changed

    optional CallQuality call_quality = 23;



    // Call quality summary at the end of a call

    optional CallQualitySummary call_quality_summary = 24;

    // Downlink call quality summary at the end of a call

    optional CallQualitySummary call_quality_summary_dl = 24;



    // Uplink call quality summary at the end of a call

    optional CallQualitySummary call_quality_summary_ul = 25;



  }

src/java/com/android/internal/telephony/metrics/CallSessionEventBuilder.java

+9 −3
Original line number Diff line number Diff line
@@ -145,9 +145,15 @@ public class CallSessionEventBuilder { 
        return this;

    }



    /** Set the signal strength. */

    public CallSessionEventBuilder setCallQualitySummary(CallQualitySummary callQualitySummary) {

        mEvent.callQualitySummary = callQualitySummary;

    /** Set the downlink call quality summary. */

    public CallSessionEventBuilder setCallQualitySummaryDl(CallQualitySummary callQualitySummary) {

        mEvent.callQualitySummaryDl = callQualitySummary;

        return this;

    }



    /** Set the uplink call quality summary. */

    public CallSessionEventBuilder setCallQualitySummaryUl(CallQualitySummary callQualitySummary) {

        mEvent.callQualitySummaryUl = callQualitySummary;

        return this;

    }

}

tests/telephonytests/src/com/android/internal/telephony/metrics/InProgressCallSessionTest.java

+2 −1
Original line number Diff line number Diff line
@@ -123,7 +123,8 @@ public class InProgressCallSessionTest extends TelephonyTest { 


        CallSessionEventBuilder builder = new CallSessionEventBuilder(

                TelephonyProto.TelephonyCallSession.Event.Type.CALL_QUALITY_CHANGED)

                .setCallQualitySummary(cqs);

                .setCallQualitySummaryDl(cqs)

                .setCallQualitySummaryUl(cqs);

        mCallSession.addEvent(builder);

        assertEquals(builder.build(), mCallSession.events.getFirst());

    }