Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 442836f8 authored Jun 28, 2023 by sangyun Committed by Sangyun Yun Aug 16, 2023

Allow PhysicalChannelConfig.build without setBand for unknown band

Allow building a PhysicalChannelConfig without setBand() if the
band is unknown, It should be enforced not to allow "unknown"
bands in the near future.

Bug: 288310456
Test: atest FrameworksTelephonyTests & tested on live network
Change-Id: I1bcdeafcb5e78859985bb100c81ad0acf88db0c2

parent 33b3edc6

src/java/com/android/internal/telephony/NetworkIndication.java

+4 −1

Original line number	Diff line number	Diff line
		@@ -168,7 +168,10 @@ public class NetworkIndication extends IRadioNetworkIndication.Stub {
		}
		if (band == PhysicalChannelConfig.BAND_UNKNOWN) {
		mRil.riljLoge("Unsupported unknown band.");
		return;
		// TODO, b/288310456,
		// If the band is unknown, PhysicalChannelConfig can be built without setBand.
		// It should be enforced not to allow "unknown" bands in the near future.
		// return;
		} else {
		builder.setBand(band);
		}

src/java/com/android/internal/telephony/RadioIndication.java

+5 −1

Original line number	Diff line number	Diff line
		@@ -1204,7 +1204,11 @@ public class RadioIndication extends IRadioIndication.Stub {
		}
		if (band == PhysicalChannelConfig.BAND_UNKNOWN) {
		mRil.riljLoge("Unsupported unknown band.");
		return;
		// TODO, b/288310456,
		// If the band is unknown, PhysicalChannelConfig can be built without
		// setBand. It should be enforced not to allow "unknown" bands in the
		// near future.
		// return;
		} else {
		builder.setBand(band);
		}