Merge "Always query ICCID from Uicc for locked SIM." am: eedd331945 (30300786) · Commits · e / os / android_frameworks_opt_telephony

src/java/com/android/internal/telephony/SubscriptionInfoUpdater.java

+14 −19

Original line number	Diff line number	Diff line
		@@ -387,8 +387,6 @@ public class SubscriptionInfoUpdater extends Handler {
		sIccId[phoneId] = null;
		}

		String iccId = sIccId[phoneId];
		if (iccId == null) {
		IccCard iccCard = PhoneFactory.getPhone(phoneId).getIccCard();
		if (iccCard == null) {
		logd("handleSimLocked: IccCard null");
		@@ -404,9 +402,6 @@ public class SubscriptionInfoUpdater extends Handler {
		return;
		}
		sIccId[phoneId] = IccUtils.stripTrailingFs(records.getFullIccId());
		} else {
		logd("NOT Querying IccId its already set sIccid[" + phoneId + "]=" + iccId);
		}

		updateSubscriptionInfoByIccId(phoneId, true /* updateEmbeddedSubs */);

+2 −1

Original line number	Diff line number	Diff line
		@@ -497,7 +497,8 @@ public class SubscriptionInfoUpdaterTest extends TelephonyTest {
		@Test
		@SmallTest
		public void testSimLockWithIccId() throws Exception {
		/* no need for IccId query */
		// ICCID will be queried even if it is already available
		doReturn("98106240020000000000").when(mIccRecord).getFullIccId();

		replaceInstance(SubscriptionInfoUpdater.class, "sIccId", null,
		new String[]{"89012604200000000000"});