Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d01df99 authored by Shuo Qian's avatar Shuo Qian
Browse files

DO NOT MERGE 

Check READ_PRIVILEGED_PHONE_STATE instead of READ_PHONE_STATE for getAvailableSubscriptionInfoList

Test: Safety net logging
Bug: 185235454

Change-Id: Ideef8793ac3c42ab30ac3004071d6be19e15b5fe
parent e8302ea6

src/java/com/android/internal/telephony/SubscriptionController.java

+18 −6
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ import android.telephony.UiccAccessRule; 
import android.telephony.euicc.EuiccManager;

import android.text.TextUtils;

import android.text.format.Time;

import android.util.EventLog;

import android.util.Log;



import com.android.internal.annotations.VisibleForTesting;
@@ -238,6 +239,11 @@ public class SubscriptionController extends ISub.Stub { 
                android.Manifest.permission.MODIFY_PHONE_STATE, message);

    }



    private void enforceReadPrivilegedPhoneState(String message) {

        mContext.enforceCallingOrSelfPermission(

                Manifest.permission.READ_PRIVILEGED_PHONE_STATE, message);

    }



    /**

     * Broadcast when SubscriptionInfo has changed

     * FIXME: Hopefully removed if the API council accepts SubscriptionInfoListener
@@ -736,12 +742,18 @@ public class SubscriptionController extends ISub.Stub { 


    @Override

    public List<SubscriptionInfo> getAvailableSubscriptionInfoList(String callingPackage) {

        // This API isn't public, so no need to provide a valid subscription ID - we're not worried

        // about carrier-privileged callers not having access.

        if (!TelephonyPermissions.checkCallingOrSelfReadPhoneState(

                mContext, SubscriptionManager.INVALID_SUBSCRIPTION_ID, callingPackage,

                "getAvailableSubscriptionInfoList")) {

            throw new SecurityException("Need READ_PHONE_STATE to call "

        try {

            enforceReadPrivilegedPhoneState("getAvailableSubscriptionInfoList");

        } catch (SecurityException e) {

            try {

                mContext.enforceCallingOrSelfPermission(Manifest.permission.READ_PHONE_STATE, null);

                // If caller doesn't have READ_PRIVILEGED_PHONE_STATE permission but only

                // has READ_PHONE_STATE permission, log this event.

                EventLog.writeEvent(0x534e4554, "185235454", Binder.getCallingUid());

            } catch (SecurityException ex) {

                // Ignore

            }

            throw new SecurityException("Need READ_PRIVILEGED_PHONE_STATE to call "

                    + " getAvailableSubscriptionInfoList");

        }