Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b210e10 authored by Tyler Gunn's avatar Tyler Gunn Committed by Android (Google) Code Review
Browse files

Merge "Document Telephony PendingIntent creation." into rvc-dev

parents f232258f 9b027694

src/java/com/android/internal/telephony/SubscriptionController.java

+3 −0
Original line number Diff line number Diff line
@@ -1846,6 +1846,9 @@ public class SubscriptionController extends ISub.Stub { 
                EuiccManager euiccManager = ((EuiccManager)

                        mContext.getSystemService(Context.EUICC_SERVICE)).createForCardId(cardId);

                euiccManager.updateSubscriptionNickname(subId, displayName,

                        // This PendingIntent simply fulfills the requirement to pass in a callback;

                        // we don't care about the result (hence 0 requestCode and no action

                        // specified on the intent).

                        PendingIntent.getService(

                            mContext, 0 /* requestCode */, new Intent(), 0 /* flags */));

            }

src/java/com/android/internal/telephony/imsphone/ImsPhone.java

+5 −0
Original line number Diff line number Diff line
@@ -1887,6 +1887,9 @@ public class ImsPhone extends ImsPhoneBase { 
                        intent.getCharSequenceExtra(EXTRA_KEY_NOTIFICATION_MESSAGE);



                Intent resultIntent = new Intent(Intent.ACTION_MAIN);

                // Note: If the classname below is ever removed, the call to

                // PendingIntent.getActivity should also specify FLAG_IMMUTABLE to ensure the

                // pending intent cannot be tampered with.

                resultIntent.setClassName("com.android.settings",

                        "com.android.settings.Settings$WifiCallingSettingsActivity");

                resultIntent.putExtra(EXTRA_KEY_ALERT_SHOW, true);
@@ -1897,6 +1900,8 @@ public class ImsPhone extends ImsPhoneBase { 
                                mContext,

                                0,

                                resultIntent,

                                // Note: Since resultIntent above specifies an explicit class name

                                // we do not need to specify PendingIntent.FLAG_IMMUTABLE here.

                                PendingIntent.FLAG_UPDATE_CURRENT

                        );