Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ac15baf authored by Jack Yu's avatar Jack Yu
Browse files

Added builder for PreciseDataConnectionState 

Added builder for PreciseDataConnectionState. No functionality
changed.

Bug: 161572838
Test: FrameworksTelephonyTests
Change-Id: Ib30674e3436d2c957c81760f4371ff8a6f7bec5e
parent b4d37fd4

src/java/com/android/internal/telephony/GsmCdmaPhone.java

+5 −6
Original line number Diff line number Diff line
@@ -65,7 +65,6 @@ import android.telephony.AccessNetworkConstants; 
import android.telephony.BarringInfo;

import android.telephony.CarrierConfigManager;

import android.telephony.CellIdentity;

import android.telephony.DataFailCause;

import android.telephony.ImsiEncryptionInfo;

import android.telephony.NetworkScanRequest;

import android.telephony.PhoneNumberUtils;
@@ -85,7 +84,6 @@ import android.util.Pair; 


import com.android.ims.ImsManager;

import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.telephony.CommandException;

import com.android.internal.telephony.cdma.CdmaMmiCode;

import com.android.internal.telephony.cdma.CdmaSubscriptionSourceManager;

import com.android.internal.telephony.dataconnection.DataEnabledSettings;
@@ -644,10 +642,11 @@ public class GsmCdmaPhone extends Phone { 
        if (mSST == null

                || ((mSST.getCurrentDataConnectionState() != ServiceState.STATE_IN_SERVICE)

                        && !isEmergencyData)) {

            return new PreciseDataConnectionState(TelephonyManager.DATA_DISCONNECTED,

                    TelephonyManager.NETWORK_TYPE_UNKNOWN,

                    ApnSetting.getApnTypesBitmaskFromString(apnType),

                    apnType, null, DataFailCause.NONE, null);

            return new PreciseDataConnectionState.Builder()

                    .setState(TelephonyManager.DATA_DISCONNECTED)

                    .setApnTypes(ApnSetting.getApnTypesBitmaskFromString(apnType))

                    .setApn(apnType)

                    .build();

        }



        // must never be null

src/java/com/android/internal/telephony/dataconnection/DcTracker.java

+8 −4
Original line number Diff line number Diff line
@@ -1178,10 +1178,14 @@ public class DcTracker extends Handler { 
        int apnTypesBitmask = ApnSetting.getApnTypesBitmaskFromString(apnType);



        // TODO: should the data fail cause be populated?

        return new PreciseDataConnectionState(

                telState, networkType, apnTypesBitmask, apnType,

                getLinkProperties(apnType),

                DataFailCause.NONE, apnSetting);

        return new PreciseDataConnectionState.Builder()

                .setState(telState)

                .setNetworkType(networkType)

                .setApnTypes(apnTypesBitmask)

                .setApn(apnType)

                .setLinkProperties(getLinkProperties(apnType))

                .setApnSetting(apnSetting)

                .build();

    }



    /**

tests/telephonytests/src/com/android/internal/telephony/TelephonyRegistryTest.java

+24 −6
Original line number Diff line number Diff line
@@ -311,8 +311,14 @@ public class TelephonyRegistryTest extends TelephonyTest { 
        // Initialize the PSL with a PreciseDataConnection

        mTelephonyRegistry.notifyDataConnectionForSubscriber(

                /*phoneId*/ 0, subId, ApnSetting.TYPE_DEFAULT,

                new PreciseDataConnectionState(

                    0, 0, 0, "default", new LinkProperties(), 0, null));

                new PreciseDataConnectionState.Builder()

                        .setState(0)

                        .setNetworkType(0)

                        .setApnTypes(0)

                        .setApn("default")

                        .setLinkProperties(new LinkProperties())

                        .setFailCause(0)

                        .build());

        mTelephonyRegistry.listenForSubscriber(subId, mContext.getOpPackageName(),

                mContext.getAttributionTag(), mPhoneStateListener.callback,

                PhoneStateListener.LISTEN_PRECISE_DATA_CONNECTION_STATE, true);
@@ -323,8 +329,14 @@ public class TelephonyRegistryTest extends TelephonyTest { 
        // Add IMS APN and verify that the listener is invoked for the IMS APN

        mTelephonyRegistry.notifyDataConnectionForSubscriber(

                /*phoneId*/ 0, subId, ApnSetting.TYPE_IMS,

                new PreciseDataConnectionState(

                    0, 0, 0, "ims", new LinkProperties(), 0, null));

                new PreciseDataConnectionState.Builder()

                        .setState(0)

                        .setNetworkType(0)

                        .setApnTypes(0)

                        .setApn("ims")

                        .setLinkProperties(new LinkProperties())

                        .setFailCause(0)

                        .build());

        processAllMessages();



        assertEquals(mPhoneStateListener.invocationCount.get(), 2);
@@ -346,8 +358,14 @@ public class TelephonyRegistryTest extends TelephonyTest { 
        // invoked.

        mTelephonyRegistry.notifyDataConnectionForSubscriber(

                /*phoneId*/ 0, subId, ApnSetting.TYPE_IMS,

                new PreciseDataConnectionState(

                    0, 0, 0, "ims", new LinkProperties(), 0, null));

                new PreciseDataConnectionState.Builder()

                        .setState(0)

                        .setNetworkType(0)

                        .setApnTypes(0)

                        .setApn("ims")

                        .setLinkProperties(new LinkProperties())

                        .setFailCause(0)

                        .build());

        processAllMessages();

        assertEquals(mPhoneStateListener.invocationCount.get(), 4);

    }