Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 193f193f authored by Tom Taylor's avatar Tom Taylor
Browse files

Externally-reported Moderate severity vulnerability in SMS: Apps can bypass... 

Externally-reported Moderate severity vulnerability in SMS: Apps can bypass the SMS short code notification prompt

Bug 22314646

When android.permission.SEND_SMS_NO_CONFIRMATION was renamed to
android.permission.SEND_RESPOND_VIA_MESSAGE in JB-MR2, the necessary change
in SmsDispatcher was accidentally overlooked.

Change-Id: I58aef2d044b8a48b1b42311a471cb112e3a258e4
parent afb60bbc

src/java/com/android/internal/telephony/SMSDispatcher.java

+3 −3
Original line number Diff line number Diff line
@@ -78,8 +78,8 @@ public abstract class SMSDispatcher extends Handler { 
    private static final String SEND_NEXT_MSG_EXTRA = "SendNextMsg";



    /** Permission required to send SMS to short codes without user confirmation. */

    private static final String SEND_SMS_NO_CONFIRMATION_PERMISSION =

            "android.permission.SEND_SMS_NO_CONFIRMATION";

    private static final String SEND_RESPOND_VIA_MESSAGE_PERMISSION =

            "android.permission.SEND_RESPOND_VIA_MESSAGE";



    private static final int PREMIUM_RULE_USE_SIM = 1;

    private static final int PREMIUM_RULE_USE_NETWORK = 2;
@@ -721,7 +721,7 @@ public abstract class SMSDispatcher extends Handler { 
     * @return true if the destination is approved; false if user confirmation event was sent

     */

    boolean checkDestination(SmsTracker tracker) {

        if (mContext.checkCallingOrSelfPermission(SEND_SMS_NO_CONFIRMATION_PERMISSION)

        if (mContext.checkCallingOrSelfPermission(SEND_RESPOND_VIA_MESSAGE_PERMISSION)

                == PackageManager.PERMISSION_GRANTED) {

            return true;            // app is pre-approved to send to short codes

        } else {