Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 144b241b authored by Jack Yu's avatar Jack Yu Committed by Android (Google) Code Review
Browse files

Merge changes from topic "get_all_subs" 

* changes:
  Added getSubscriptionsInGroup support
  Added few more APIs support
parents 74f163da eda64281

src/java/com/android/internal/telephony/GsmCdmaPhone.java

+30 −19
Original line number Diff line number Diff line
@@ -104,6 +104,7 @@ import com.android.internal.telephony.imsphone.ImsPhoneCallTracker; 
import com.android.internal.telephony.imsphone.ImsPhoneMmiCode;

import com.android.internal.telephony.metrics.TelephonyMetrics;

import com.android.internal.telephony.metrics.VoiceCallSessionStats;

import com.android.internal.telephony.subscription.SubscriptionInfoInternal;

import com.android.internal.telephony.subscription.SubscriptionManagerService.SubscriptionManagerServiceCallback;

import com.android.internal.telephony.test.SimulatedRadioControl;

import com.android.internal.telephony.uicc.IccCardApplicationStatus.AppType;
@@ -4857,18 +4858,28 @@ public class GsmCdmaPhone extends Phone { 
            return;

        }



        SubscriptionInfo info = SubscriptionController.getInstance().getSubInfoForIccId(

        SubscriptionInfo info;

        if (isSubscriptionManagerServiceEnabled()) {

            info = mSubscriptionManagerService

                    .getAllSubInfoList(mContext.getOpPackageName(), mContext.getAttributionTag())

                    .stream()

                    .filter(subInfo -> subInfo.getIccId().equals(IccUtils.stripTrailingFs(iccId)))

                    .findFirst()

                    .orElse(null);

        } else {

            info = SubscriptionController.getInstance().getSubInfoForIccId(

                    IccUtils.stripTrailingFs(iccId));

        }



        // If info is null, it could be a new subscription. By default we enable it.

        boolean expectedValue = info == null ? true : info.areUiccApplicationsEnabled();

        boolean expectedValue = info == null || info.areUiccApplicationsEnabled();



        // If for any reason current state is different from configured state, re-apply the

        // configured state.

        if (expectedValue != mUiccApplicationsEnabled) {

            mCi.enableUiccApplications(expectedValue, Message.obtain(

                    this, EVENT_REAPPLY_UICC_APPS_ENABLEMENT_DONE,

                    new Pair<Boolean, Integer>(expectedValue, retries)));

                    new Pair<>(expectedValue, retries)));

        }

    }
@@ -4960,14 +4971,20 @@ public class GsmCdmaPhone extends Phone { 
        boolean mDefaultVonr =

                config.getBoolean(CarrierConfigManager.KEY_VONR_ON_BY_DEFAULT_BOOL);



        String result = SubscriptionController.getInstance().getSubscriptionProperty(

                getSubId(),

                SubscriptionManager.NR_ADVANCED_CALLING_ENABLED);



        int setting = -1;

        if (isSubscriptionManagerServiceEnabled()) {

            SubscriptionInfoInternal subInfo = mSubscriptionManagerService

                    .getSubscriptionInfoInternal(getSubId());

            if (subInfo != null) {

                setting = subInfo.getNrAdvancedCallingEnabled();

            }

        } else {

            String result = SubscriptionController.getInstance().getSubscriptionProperty(

                    getSubId(), SubscriptionManager.NR_ADVANCED_CALLING_ENABLED);

            if (result != null) {

                setting = Integer.parseInt(result);

            }

        }



        logd("VoNR setting from telephony.db:"

                + setting
@@ -4976,15 +4993,9 @@ public class GsmCdmaPhone extends Phone { 
                + " ,vonr_on_by_default_bool:"

                + mDefaultVonr);



        if (!mIsVonrEnabledByCarrier) {

            mCi.setVoNrEnabled(false, obtainMessage(EVENT_SET_VONR_ENABLED_DONE), null);

        } else if (setting == -1) {

            mCi.setVoNrEnabled(mDefaultVonr, obtainMessage(EVENT_SET_VONR_ENABLED_DONE), null);

        } else if (setting == 1) {

            mCi.setVoNrEnabled(true, obtainMessage(EVENT_SET_VONR_ENABLED_DONE), null);

        } else if (setting == 0) {

            mCi.setVoNrEnabled(false, obtainMessage(EVENT_SET_VONR_ENABLED_DONE), null);

        }

        boolean enbleVonr = mIsVonrEnabledByCarrier

                && (setting == 1 || (setting == -1 && mDefaultVonr));

        mCi.setVoNrEnabled(enbleVonr, obtainMessage(EVENT_SET_VONR_ENABLED_DONE), null);

    }



    private void updateCdmaRoamingSettingsAfterCarrierConfigChanged(PersistableBundle config) {

src/java/com/android/internal/telephony/MultiSimSettingController.java

+11 −5
Original line number Diff line number Diff line
@@ -54,6 +54,7 @@ import android.util.Log; 


import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.telephony.data.DataSettingsManager.DataSettingsManagerCallback;

import com.android.internal.telephony.subscription.SubscriptionManagerService;

import com.android.internal.telephony.util.ArrayUtils;



import java.lang.annotation.Retention;
@@ -903,11 +904,16 @@ public class MultiSimSettingController extends Handler { 
     * are synced.

     */

    private void setRoamingDataEnabledForGroup(int subId, boolean enable) {

        SubscriptionController subController = SubscriptionController.getInstance();

        List<SubscriptionInfo> infoList = subController.getSubscriptionsInGroup(

        List<SubscriptionInfo> infoList;

        if (PhoneFactory.getDefaultPhone().isSubscriptionManagerServiceEnabled()) {

            infoList = SubscriptionManagerService.getInstance().getSubscriptionsInGroup(

                    mSubController.getGroupUuid(subId), mContext.getOpPackageName(),

                    mContext.getAttributionTag());



        } else {

            infoList = SubscriptionController.getInstance().getSubscriptionsInGroup(

                    mSubController.getGroupUuid(subId), mContext.getOpPackageName(),

                    mContext.getAttributionTag());

        }

        if (infoList == null) return;



        for (SubscriptionInfo info : infoList) {

src/java/com/android/internal/telephony/subscription/SubscriptionInfoInternal.java

+11 −9
Original line number Diff line number Diff line
@@ -628,11 +628,12 @@ public class SubscriptionInfoInternal { 
     * @return {@code true} if enhanced 4G mode is enabled by the user or not.

     */

    public boolean isEnhanced4GModeEnabled() {

        return mIsEnhanced4GModeEnabled != 0;

        return mIsEnhanced4GModeEnabled == 1;

    }



    /**

     * @return {@code 1} if enhanced 4G mode is enabled by the user or not.

     * @return {@code 1} if enhanced 4G mode is enabled by the user or not. {@code 0} if disabled.

     * {@code -1} if the user did not change any setting.

     */

    public int getEnhanced4GModeEnabled() {

        return mIsEnhanced4GModeEnabled;
@@ -657,12 +658,12 @@ public class SubscriptionInfoInternal { 
     * roaming.

     */

    public boolean isWifiCallingEnabled() {

        return mIsWifiCallingEnabled != 0;

        return mIsWifiCallingEnabled == 1;

    }



    /**

     * @return {@code 1} if Wi-Fi calling is enabled by the user or not when the device is not

     * roaming.

     * roaming. {@code 0} if disabled. {@code -1} if the user did not change any setting.

     */

    public int getWifiCallingEnabled() {

        return mIsWifiCallingEnabled;
@@ -686,10 +687,10 @@ public class SubscriptionInfoInternal { 


    /**

     * @return {@code true} if Wi-Fi calling is enabled by the user or not when the device is

     * roaming.

     * roaming. {@code 0} if disabled. {@code -1} if the user did not change any setting.

     */

    public boolean isWifiCallingEnabledForRoaming() {

        return mIsWifiCallingEnabledForRoaming != 0;

        return mIsWifiCallingEnabledForRoaming == 1;

    }



    /**
@@ -894,11 +895,12 @@ public class SubscriptionInfoInternal { 
     * @return {@code true} if the user has enabled NR advanced calling.

     */

    public boolean isNrAdvancedCallingEnabled() {

        return mIsNrAdvancedCallingEnabled != 0;

        return mIsNrAdvancedCallingEnabled == 1;

    }



    /**

     * @return {@code 1} if the user has enabled NR advanced calling.

     * @return {@code 1} if the user has enabled NR advanced calling. {code 0} if disabled.

     * {code -1} if the user did not change any setting.

     */

    public int getNrAdvancedCallingEnabled() {

        return mIsNrAdvancedCallingEnabled;
@@ -1407,7 +1409,7 @@ public class SubscriptionInfoInternal { 
        /**

         * Whether the user has enabled NR advanced calling.

         */

        private int mIsNrAdvancedCallingEnabled = 0;

        private int mIsNrAdvancedCallingEnabled = -1;



        /**

         * The phone number retrieved from carrier.

src/java/com/android/internal/telephony/subscription/SubscriptionManagerService.java

+251 −22

File changed.

Preview size limit exceeded, changes collapsed.

tests/telephonytests/src/com/android/internal/telephony/subscription/SubscriptionManagerServiceTest.java

+245 −0
Original line number Diff line number Diff line
@@ -21,38 +21,73 @@ import static com.android.internal.telephony.subscription.SubscriptionDatabaseMa 
import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_CARRIER_NAME1;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_COUNTRY_CODE2;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_ICCID1;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_ICCID2;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_MCC2;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_MNC2;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_PHONE_NUMBER1;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_PHONE_NUMBER2;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_SUBSCRIPTION_INFO1;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_SUBSCRIPTION_INFO2;

import static com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.FAKE_UUID1;



import static com.google.common.truth.Truth.assertThat;



import static org.junit.Assert.assertThrows;

import static org.junit.Assert.fail;

import static org.mockito.ArgumentMatchers.any;

import static org.mockito.ArgumentMatchers.anyInt;

import static org.mockito.ArgumentMatchers.anyString;

import static org.mockito.ArgumentMatchers.eq;

import static org.mockito.ArgumentMatchers.nullable;

import static org.mockito.Mockito.doAnswer;

import static org.mockito.Mockito.doNothing;

import static org.mockito.Mockito.doReturn;

import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;



import android.Manifest;

import android.annotation.NonNull;

import android.app.AppOpsManager;

import android.app.PropertyInvalidatedCache;

import android.compat.testing.PlatformCompatChangeRule;

import android.content.pm.PackageManager;

import android.os.Build;

import android.os.Looper;

import android.os.ParcelUuid;

import android.provider.Telephony;

import android.telephony.SubscriptionInfo;

import android.telephony.SubscriptionManager;

import android.test.mock.MockContentResolver;

import android.testing.AndroidTestingRunner;

import android.testing.TestableLooper;



import com.android.internal.telephony.ContextFixture;

import com.android.internal.telephony.TelephonyTest;

import com.android.internal.telephony.subscription.SubscriptionDatabaseManagerTest.SubscriptionProvider;

import com.android.internal.telephony.subscription.SubscriptionManagerService.SubscriptionManagerServiceCallback;



import libcore.junit.util.compat.CoreCompatChangeRule.EnableCompatChanges;



import org.junit.After;

import org.junit.Before;

import org.junit.Rule;

import org.junit.Test;

import org.junit.rules.TestRule;

import org.junit.runner.RunWith;

import org.mockito.Mockito;



import java.lang.reflect.Field;

import java.lang.reflect.Method;

import java.util.List;



@RunWith(AndroidTestingRunner.class)

@TestableLooper.RunWithLooper

public class SubscriptionManagerServiceTest extends TelephonyTest {



    private static final String CALLING_PACKAGE = "calling_package";



    private static final String CALLING_FEATURE = "calling_feature";



    private SubscriptionManagerService mSubscriptionManagerServiceUT;



    private final SubscriptionProvider mSubscriptionProvider = new SubscriptionProvider();
@@ -60,10 +95,15 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 
    // mocked

    private SubscriptionManagerServiceCallback mMockedSubscriptionManagerServiceCallback;



    @Rule

    public TestRule compatChangeRule = new PlatformCompatChangeRule();



    @Before

    public void setUp() throws Exception {

        logd("SubscriptionManagerServiceTest +Setup!");

        super.setUp(getClass().getSimpleName());

        setupMocksForTelephonyPermissions(Build.VERSION_CODES.UPSIDE_DOWN_CAKE);

        PropertyInvalidatedCache.disableForCurrentProcess("cache_key.is_compat_change_enabled");



        mMockedSubscriptionManagerServiceCallback = Mockito.mock(

                SubscriptionManagerServiceCallback.class);
@@ -81,6 +121,13 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 
        waitForMs(100);

        processAllFutureMessages();



        // Revoke all permissions.

        mContextFixture.removeCallingOrSelfPermission(ContextFixture.PERMISSION_ENABLE_ALL);

        doReturn(AppOpsManager.MODE_DEFAULT).when(mAppOpsManager).noteOpNoThrow(anyString(),

                anyInt(), nullable(String.class), nullable(String.class), nullable(String.class));

        setIdentifierAccess(false);

        setPhoneNumberAccess(PackageManager.PERMISSION_DENIED);



        logd("SubscriptionManagerServiceTest -Setup!");

    }
@@ -89,8 +136,28 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 
        super.tearDown();

    }



    private void insertSubscription(@NonNull SubscriptionInfoInternal subInfo) {

        try {

            Field field = SubscriptionManagerService.class.getDeclaredField(

                    "mSubscriptionDatabaseManager");

            field.setAccessible(true);

            SubscriptionDatabaseManager sdbm =

                    (SubscriptionDatabaseManager) field.get(mSubscriptionManagerServiceUT);



            Class[] cArgs = new Class[1];

            cArgs[0] = SubscriptionInfoInternal.class;

            Method method = SubscriptionDatabaseManager.class.getDeclaredMethod(

                    "insertSubscriptionInfo", cArgs);

            method.setAccessible(true);

            method.invoke(sdbm, subInfo);

        } catch (Exception e) {

            fail("Failed to insert subscription. e=" + e);

        }

    }



    @Test

    public void testAddSubInfo() {

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.MODIFY_PHONE_STATE);

        mSubscriptionManagerServiceUT.addSubInfo(FAKE_ICCID1, FAKE_CARRIER_NAME1,

                0, SubscriptionManager.SUBSCRIPTION_TYPE_LOCAL_SIM);

        processAllMessages();
@@ -108,6 +175,7 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 


    @Test

    public void testSetMccMnc() {

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.MODIFY_PHONE_STATE);

        mSubscriptionManagerServiceUT.addSubInfo(FAKE_ICCID1, FAKE_CARRIER_NAME1,

                0, SubscriptionManager.SUBSCRIPTION_TYPE_LOCAL_SIM);

        processAllMessages();
@@ -127,6 +195,7 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 


    @Test

    public void testSetCountryIso() {

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.MODIFY_PHONE_STATE);

        mSubscriptionManagerServiceUT.addSubInfo(FAKE_ICCID1, FAKE_CARRIER_NAME1,

                0, SubscriptionManager.SUBSCRIPTION_TYPE_LOCAL_SIM);

        processAllMessages();
@@ -145,6 +214,7 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 


    @Test

    public void testSetCarrierId() {

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.MODIFY_PHONE_STATE);

        mSubscriptionManagerServiceUT.addSubInfo(FAKE_ICCID1, FAKE_CARRIER_NAME1,

                0, SubscriptionManager.SUBSCRIPTION_TYPE_LOCAL_SIM);

        processAllMessages();
@@ -160,4 +230,179 @@ public class SubscriptionManagerServiceTest extends TelephonyTest { 
        assertThat(subInfo.getCarrierId()).isEqualTo(FAKE_CARRIER_ID2);

        verify(mMockedSubscriptionManagerServiceCallback).onSubscriptionChanged(eq(1));

    }



    @Test

    public void testSetPhoneNumber() {

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.MODIFY_PHONE_STATE);

        mSubscriptionManagerServiceUT.addSubInfo(FAKE_ICCID1, FAKE_CARRIER_NAME1,

                0, SubscriptionManager.SUBSCRIPTION_TYPE_LOCAL_SIM);

        processAllMessages();



        verify(mMockedSubscriptionManagerServiceCallback).onSubscriptionChanged(eq(1));

        Mockito.clearInvocations(mMockedSubscriptionManagerServiceCallback);



        // Source IMS is not acceptable

        assertThrows(IllegalArgumentException.class,

                () -> mSubscriptionManagerServiceUT.setPhoneNumber(1,

                        SubscriptionManager.PHONE_NUMBER_SOURCE_IMS, FAKE_PHONE_NUMBER2,

                        CALLING_PACKAGE, CALLING_FEATURE));



        // Caller does not have carrier privilege

        assertThrows(SecurityException.class,

                () -> mSubscriptionManagerServiceUT.setPhoneNumber(1,

                        SubscriptionManager.PHONE_NUMBER_SOURCE_CARRIER, FAKE_PHONE_NUMBER2,

                        CALLING_PACKAGE, CALLING_FEATURE));



        // Grant carrier privilege

        setCarrierPrivilegesForSubId(true, 1);



        mSubscriptionManagerServiceUT.setPhoneNumber(1,

                SubscriptionManager.PHONE_NUMBER_SOURCE_CARRIER, FAKE_PHONE_NUMBER2,

                CALLING_PACKAGE, CALLING_FEATURE);

        processAllMessages();



        SubscriptionInfoInternal subInfo = mSubscriptionManagerServiceUT

                .getSubscriptionInfoInternal(1);

        assertThat(subInfo).isNotNull();

        assertThat(subInfo.getNumberFromCarrier()).isEqualTo(FAKE_PHONE_NUMBER2);

        verify(mMockedSubscriptionManagerServiceCallback).onSubscriptionChanged(eq(1));

    }



    @Test

    public void testGetAllSubInfoList() {

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.MODIFY_PHONE_STATE);

        doReturn(new int[]{1, 2}).when(mSubscriptionManager).getCompleteActiveSubscriptionIdList();

        insertSubscription(FAKE_SUBSCRIPTION_INFO1);

        insertSubscription(FAKE_SUBSCRIPTION_INFO2);

        processAllMessages();



        verify(mMockedSubscriptionManagerServiceCallback).onSubscriptionChanged(eq(2));



        // Should throw security exception if the caller does not have permission.

        assertThrows(SecurityException.class,

                () -> mSubscriptionManagerServiceUT.getAllSubInfoList(

                        CALLING_PACKAGE, CALLING_FEATURE));



        // Grant carrier privilege for sub 1

        setCarrierPrivilegesForSubId(true, 1);

        // Grant carrier privilege for sub 2

        setCarrierPrivilegesForSubId(true, 2);



        List<SubscriptionInfo> subInfos = mSubscriptionManagerServiceUT.getAllSubInfoList(

                CALLING_PACKAGE, CALLING_FEATURE);

        assertThat(subInfos).hasSize(2);



        assertThat(subInfos.get(0)).isEqualTo(new SubscriptionInfoInternal

                .Builder(FAKE_SUBSCRIPTION_INFO1)

                .setId(1).build().toSubscriptionInfo());



        assertThat(subInfos.get(1)).isEqualTo(new SubscriptionInfoInternal

                .Builder(FAKE_SUBSCRIPTION_INFO2)

                .setId(2).build().toSubscriptionInfo());



        // Revoke carrier privilege for sub 2

        setCarrierPrivilegesForSubId(false, 2);



        subInfos = mSubscriptionManagerServiceUT.getAllSubInfoList(

                CALLING_PACKAGE, CALLING_FEATURE);

        assertThat(subInfos).hasSize(2);



        assertThat(subInfos.get(0).getIccId()).isEqualTo(FAKE_ICCID1);

        assertThat(subInfos.get(0).getCardString()).isEqualTo(FAKE_ICCID1);

        assertThat(subInfos.get(0).getNumber()).isEqualTo(FAKE_PHONE_NUMBER1);

        // identifiers should be empty due to insufficient permission.

        assertThat(subInfos.get(1).getIccId()).isEmpty();

        assertThat(subInfos.get(1).getCardString()).isEmpty();

        assertThat(subInfos.get(1).getNumber()).isEmpty();



        // Grant READ_PHONE_STATE permission

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.READ_PHONE_STATE);

        // Grant identifier access

        setIdentifierAccess(true);

        // Revoke carrier privileges.

        setCarrierPrivilegesForSubId(false, 1);

        setCarrierPrivilegesForSubId(false, 2);



        subInfos = mSubscriptionManagerServiceUT.getAllSubInfoList(

                CALLING_PACKAGE, CALLING_FEATURE);

        assertThat(subInfos).hasSize(2);



        assertThat(subInfos.get(0).getIccId()).isEqualTo(FAKE_ICCID1);

        assertThat(subInfos.get(0).getCardString()).isEqualTo(FAKE_ICCID1);

        // Phone number should be empty

        assertThat(subInfos.get(0).getNumber()).isEmpty();

        assertThat(subInfos.get(1).getIccId()).isEqualTo(FAKE_ICCID2);

        assertThat(subInfos.get(1).getCardString()).isEqualTo(FAKE_ICCID2);

        // Phone number should be empty

        assertThat(subInfos.get(1).getNumber()).isEmpty();



        // Grant phone number access

        doReturn(PackageManager.PERMISSION_GRANTED).when(mMockLegacyPermissionManager)

                .checkPhoneNumberAccess(anyString(), anyString(), anyString(), anyInt(), anyInt());



        subInfos = mSubscriptionManagerServiceUT.getAllSubInfoList(

                CALLING_PACKAGE, CALLING_FEATURE);

        assertThat(subInfos).hasSize(2);

        assertThat(subInfos.get(0).getNumber()).isEqualTo(FAKE_PHONE_NUMBER1);

        assertThat(subInfos.get(1).getNumber()).isEqualTo(FAKE_PHONE_NUMBER2);

    }



    @Test

    @EnableCompatChanges({SubscriptionManagerService.REQUIRE_DEVICE_IDENTIFIERS_FOR_GROUP_UUID})

    public void testGetSubscriptionsInGroup() {

        doReturn(new int[]{1, 2}).when(mSubscriptionManager).getCompleteActiveSubscriptionIdList();



        insertSubscription(FAKE_SUBSCRIPTION_INFO1);

        SubscriptionInfoInternal anotherSubInfo =

                new SubscriptionInfoInternal.Builder(FAKE_SUBSCRIPTION_INFO2)

                        .setGroupUuid(FAKE_UUID1)

                        .build();

        insertSubscription(anotherSubInfo);



        // Throw exception is the new behavior.

        assertThrows(SecurityException.class,

                () -> mSubscriptionManagerServiceUT.getSubscriptionsInGroup(

                        ParcelUuid.fromString(FAKE_UUID1), CALLING_PACKAGE, CALLING_FEATURE));



        // Grant carrier privilege on sub 1 and 2

        setCarrierPrivilegesForSubId(true, 1);

        setCarrierPrivilegesForSubId(true, 2);

        List<SubscriptionInfo> subInfos = mSubscriptionManagerServiceUT.getSubscriptionsInGroup(

                ParcelUuid.fromString(FAKE_UUID1), CALLING_PACKAGE, CALLING_FEATURE);



        assertThat(subInfos).hasSize(2);

        assertThat(subInfos.get(0)).isEqualTo(new SubscriptionInfoInternal.Builder(

                FAKE_SUBSCRIPTION_INFO1).setId(1).build().toSubscriptionInfo());

        assertThat(subInfos.get(1)).isEqualTo(new SubscriptionInfoInternal.Builder(anotherSubInfo)

                .setId(2).build().toSubscriptionInfo());



        // Grant READ_PHONE_STATE permission

        mContextFixture.addCallingOrSelfPermission(Manifest.permission.READ_PHONE_STATE);

        setIdentifierAccess(false);

        setCarrierPrivilegesForSubId(false, 1);

        setCarrierPrivilegesForSubId(false, 2);

        doNothing().when(mContext).enforcePermission(

                eq(android.Manifest.permission.READ_PHONE_STATE), anyInt(), anyInt(), anyString());



        // Throw exception is the new behavior. Only has READ_PHONE_STATE is not enough. Need

        // identifier access as well.

        assertThrows(SecurityException.class,

                () -> mSubscriptionManagerServiceUT.getSubscriptionsInGroup(

                        ParcelUuid.fromString(FAKE_UUID1), CALLING_PACKAGE, CALLING_FEATURE));



        // Grant identifier access

        setIdentifierAccess(true);

        // Grant phone number access

        setPhoneNumberAccess(PackageManager.PERMISSION_GRANTED);



        subInfos = mSubscriptionManagerServiceUT.getSubscriptionsInGroup(

                ParcelUuid.fromString(FAKE_UUID1), CALLING_PACKAGE, CALLING_FEATURE);



        assertThat(subInfos).hasSize(2);

        assertThat(subInfos).containsExactlyElementsIn(

                List.of(new SubscriptionInfoInternal.Builder(FAKE_SUBSCRIPTION_INFO1)

                                .setId(1).build().toSubscriptionInfo(),

                        new SubscriptionInfoInternal.Builder(anotherSubInfo)

                                .setId(2).build().toSubscriptionInfo()));

    }

}