Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0fd91c20 authored by Sarah Chin's avatar Sarah Chin
Browse files

Update default MTU value to 1500 

Use KEY_DEFAULT_MTU_INT instead of hardcoded value

Test: atest DataNetworkTest
Bug: 235409168
Change-Id: Ic69efdd6c63f2f7ba7486060750c9d8ef0b84ebc
parent 37e87601

src/java/com/android/internal/telephony/data/DataNetwork.java

+2 −8
Original line number Diff line number Diff line
@@ -231,12 +231,6 @@ public class DataNetwork extends StateMachine { 
    /** Event for CSS indicator changed. */

    private static final int EVENT_CSS_INDICATOR_CHANGED = 24;



    /** The default MTU for IPv4 network. */

    private static final int DEFAULT_MTU_V4 = 1280;



    /** The default MTU for IPv6 network. */

    private static final int DEFAULT_MTU_V6 = 1280;



    /** Invalid context id. */

    private static final int INVALID_CID = -1;
@@ -2220,7 +2214,7 @@ public class DataNetwork extends StateMachine { 
                mtuV4 = mDataProfile.getApnSetting().getMtuV4();

            }

            if (mtuV4 <= 0) {

                mtuV4 = DEFAULT_MTU_V4;

                mtuV4 = mDataConfigManager.getDefaultMtu();

            }

        }
@@ -2232,7 +2226,7 @@ public class DataNetwork extends StateMachine { 
                mtuV6 = mDataProfile.getApnSetting().getMtuV6();

            }

            if (mtuV6 <= 0) {

                mtuV6 = DEFAULT_MTU_V6;

                mtuV6 = mDataConfigManager.getDefaultMtu();

            }

        }

tests/telephonytests/src/com/android/internal/telephony/data/DataNetworkTest.java

+6 −3
Original line number Diff line number Diff line
@@ -102,6 +102,8 @@ public class DataNetworkTest extends TelephonyTest { 
    private static final int ADMIN_UID1 = 1234;

    private static final int ADMIN_UID2 = 5678;



    private static final int DEFAULT_MTU = 1501;



    private static final String FAKE_IMSI = "123456789";



    private DataNetwork mDataNetworkUT;
@@ -218,7 +220,6 @@ public class DataNetworkTest extends TelephonyTest { 
                            InetAddresses.parseNumericAddress("fd00:976a:c202:1d::7"),

                            InetAddresses.parseNumericAddress("fd00:976a:c305:1d::5")))

                    .setMtuV4(1234)

                    .setMtuV6(5678)

                    .setPduSessionId(1)

                    .setQosBearerSessions(new ArrayList<>())

                    .setTrafficDescriptors(tds)
@@ -318,6 +319,7 @@ public class DataNetworkTest extends TelephonyTest { 
                .when(mDataConfigManager).getBandwidthEstimateSource();

        doReturn(true).when(mDataConfigManager).isTempNotMeteredSupportedByCarrier();

        doReturn(true).when(mDataConfigManager).isImsDelayTearDownEnabled();

        doReturn(DEFAULT_MTU).when(mDataConfigManager).getDefaultMtu();

        doReturn(FAKE_IMSI).when(mPhone).getSubscriberId();

        doReturn(true).when(mDataNetworkController)

                .isNetworkRequestExisting(any(TelephonyNetworkRequest.class));
@@ -402,9 +404,10 @@ public class DataNetworkTest extends TelephonyTest { 
        assertThat(lp.getRoutes().get(0).getMtu()).isEqualTo(1234);

        assertThat(lp.getRoutes().get(1).getGateway()).isEqualTo(

                InetAddresses.parseNumericAddress("fe80::2"));

        assertThat(lp.getRoutes().get(1).getMtu()).isEqualTo(5678);

        // The default from carrier configs should be used if MTU is not set.

        assertThat(lp.getRoutes().get(1).getMtu()).isEqualTo(DEFAULT_MTU);

        // The higher value of v4 and v6 should be used.

        assertThat(lp.getMtu()).isEqualTo(5678);

        assertThat(lp.getMtu()).isEqualTo(DEFAULT_MTU);



        ArgumentCaptor<PreciseDataConnectionState> pdcsCaptor =

                ArgumentCaptor.forClass(PreciseDataConnectionState.class);