Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06798370 authored by Ling Ma's avatar Ling Ma
Browse files

Refine invalid DataCallResponse anomaly detection 

Exclude inactive PDN from dataCallResponse anomaly detection as it signals the end of PDN life cycle.

Bug: 232618538
Test: manual sanity
Change-Id: Ie6eca088260228460f8bbd870a78a069349711ad
parent 5a1a044e

src/java/com/android/internal/telephony/data/DataNetwork.java

+3 −2
Original line number Diff line number Diff line
@@ -2356,7 +2356,8 @@ public class DataNetwork extends StateMachine { 
     * @param response The response to be validated

     */

    private void validateDataCallResponse(@Nullable DataCallResponse response) {

        if (response == null) return;

        if (response == null

                || response.getLinkStatus() == DataCallResponse.LINK_STATUS_INACTIVE) return;

        int failCause = response.getCause();

        if (failCause == DataFailCause.NONE) {

            if (TextUtils.isEmpty(response.getInterfaceName())
@@ -2372,7 +2373,7 @@ public class DataNetwork extends StateMachine { 
                    > DataCallResponse.HANDOVER_FAILURE_MODE_NO_FALLBACK_RETRY_SETUP_NORMAL) {

                loge("Invalid DataCallResponse:" + response);

                reportAnomaly("Invalid DataCallResponse detected",

                        "9f775beb-c638-44d2-833a-8c3875fee2d1");

                        "1f273e9d-b09c-46eb-ad1c-421d01f61164");

            }

        } else if (!DataFailCause.isFailCauseExisting(failCause)) { // Setup data failed.

            loge("Invalid DataFailCause in " + response);