Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04b79910 authored by Pengquan Meng's avatar Pengquan Meng
Browse files

Fixed invalid phone id for active subscription change event 

Bug: 129030675
Test: build & manual test
Change-Id: I8a8a85919a63815f0c3f5bae39af34d33c5b036d
parent bf673d01

src/java/com/android/internal/telephony/SubscriptionController.java

+2 −1
Original line number Diff line number Diff line
@@ -307,7 +307,8 @@ public class SubscriptionController extends ISub.Stub { 
        broadcastSimInfoContentChanged();



        TelephonyMetrics metrics = TelephonyMetrics.getInstance();

        metrics.updateActiveSubscriptionInfoList(mCacheActiveSubInfoList);

        metrics.updateActiveSubscriptionInfoList(

                Collections.unmodifiableList(mCacheActiveSubInfoList));

    }



    /**

src/java/com/android/internal/telephony/metrics/TelephonyMetrics.java

+2 −2
Original line number Diff line number Diff line
@@ -714,14 +714,14 @@ public class TelephonyMetrics { 
    }



    /** Update active subscription info list. */

    public void updateActiveSubscriptionInfoList(List<SubscriptionInfo> subInfos) {

    public synchronized void updateActiveSubscriptionInfoList(List<SubscriptionInfo> subInfos) {

        List<Integer> inActivePhoneList = new ArrayList<>();

        for (int i = 0; i < mLastActiveSubscriptionInfos.size(); i++) {

            inActivePhoneList.add(mLastActiveSubscriptionInfos.keyAt(i));

        }



        for (SubscriptionInfo info : subInfos) {

            int phoneId = SubscriptionManager.getPhoneId(info.getSubscriptionId());

            int phoneId = info.getSimSlotIndex();

            inActivePhoneList.removeIf(value -> value.equals(phoneId));

            ActiveSubscriptionInfo activeSubscriptionInfo = new ActiveSubscriptionInfo();

            activeSubscriptionInfo.slotIndex = phoneId;