Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fe82e54b authored by Steven Moreland's avatar Steven Moreland
Browse files

binder_process.h: clarify thread start behavior 

Be explicit that joinThreadPool does not also start the threadpool.

Bug: N/A (email thread)
Change-Id: I0572dfbdbf152502fbde6f8cdd624b5b2025459f
Test: N/A
parent 382fc4d2

libs/binder/ndk/include_platform/android/binder_process.h

+7 −4
Original line number Original line Diff line number Diff line
@@ -47,8 +47,11 @@ void ABinderProcess_startThreadPool(void); 
 * be called once before startThreadPool. The number of threads can never decrease.

 * be called once before startThreadPool. The number of threads can never decrease.

 *

 *

 * This count refers to the number of threads that will be created lazily by the kernel, in

 * This count refers to the number of threads that will be created lazily by the kernel, in

 * addition to the threads created by ABinderProcess_startThreadPool or

 * addition to the single threads created by ABinderProcess_startThreadPool (+1) or

 * ABinderProcess_joinThreadPool.

 * ABinderProcess_joinThreadPool (+1). Note: ABinderProcess_startThreadPool starts a thread

 * itself, but it also enables up to the number of threads passed to this function to start.

 * This function does not start any threads itself; it only configures

 * ABinderProcess_startThreadPool.

 *

 *

 * Do not use this from a library. Apps setup their own threadpools, and otherwise, the main

 * Do not use this from a library. Apps setup their own threadpools, and otherwise, the main

 * function should be responsible for configuring the threadpool for the entire application.

 * function should be responsible for configuring the threadpool for the entire application.
@@ -63,8 +66,8 @@ bool ABinderProcess_setThreadPoolMaxThreadCount(uint32_t numThreads); 
bool ABinderProcess_isThreadPoolStarted(void);

bool ABinderProcess_isThreadPoolStarted(void);

/**

/**

 * This adds the current thread to the threadpool. This thread will be in addition to the thread

 * This adds the current thread to the threadpool. This thread will be in addition to the thread

 * started by ABinderProcess_startThreadPool and the lazy kernel-started threads specified by

 * configured with ABinderProcess_setThreadPoolMaxThreadCount and started with

 * ABinderProcess_setThreadPoolMaxThreadCount.

 * ABinderProcess_startThreadPool.

 *

 *

 * Do not use this from a library. Apps setup their own threadpools, and otherwise, the main

 * Do not use this from a library. Apps setup their own threadpools, and otherwise, the main

 * function should be responsible for configuring the threadpool for the entire application.

 * function should be responsible for configuring the threadpool for the entire application.