Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fc6f52e8 authored by Devin Moore's avatar Devin Moore
Browse files

Remove AddAccessorEmpty test case in binderAllocationLimits 

The ALOGE sometimes doesn't cause an allocation and that makes this test
case flaky.

It's not a very important test case, as it is only verifying no
allocations occur(outside of that log) in an uncomon failure case when
trying to inject Accessors with an empty list of instances.

Flag: TEST_ONLY
Bug: 427290547
Test: atest binderAllocationLimits
Change-Id: I96b06d375c733fe63216ad1b76148a2ac19cacbc
parent 1f38ae3e

libs/binder/tests/binderAllocationLimits.cpp

+0 −14
Original line number Diff line number Diff line
@@ -323,20 +323,6 @@ TEST(BinderAccessorAllocation, AddAccessorCheckService) { 
    status_t status = android::removeAccessorProvider(receipt);

}



TEST(BinderAccessorAllocation, AddAccessorEmpty) {

    std::vector<size_t> expectedMallocs = {

            48, // From ALOGE with empty set of instances

    };

    std::set<std::string> supportedInstances = {};

    auto onMalloc = setExpectedMallocs(std::move(expectedMallocs));



    auto receipt =

            android::addAccessorProvider(std::move(supportedInstances),

                                         [&](const String16&) -> sp<IBinder> { return nullptr; });



    EXPECT_TRUE(receipt.expired());

}



TEST(RpcBinderAllocation, SetupRpcServer) {

    std::string tmp = getenv("TMPDIR") ?: "/tmp";

    std::string addr = tmp + "/binderRpcBenchmark";