Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb7fad03 authored by Derek Wu's avatar Derek Wu
Browse files

Revert "Add flag to enable jerk prediction pruning." 

This reverts commit fe8bbb039dbe458b485c055bbfc6b862681809f3.

Reason for revert: Performance regression: b/330854747

BUG: 330854747
Change-Id: I323b13594fd271af5f73579218fe4797ea0d6b92
parent 1af8b968

libs/input/MotionPredictor.cpp

+1 −12
Original line number Diff line number Diff line
@@ -22,21 +22,17 @@ 
#include <cmath>

#include <cstddef>

#include <cstdint>

#include <limits>

#include <string>

#include <vector>



#include <android-base/logging.h>

#include <android-base/strings.h>

#include <android/input.h>

#include <com_android_input_flags.h>



#include <attestation/HmacKeyManager.h>

#include <ftl/enum.h>

#include <input/TfLiteMotionPredictor.h>



namespace input_flags = com::android::input::flags;



namespace android {

namespace {
@@ -201,14 +197,7 @@ std::unique_ptr<MotionEvent> MotionPredictor::predict(nsecs_t timestamp) { 
            // device starts to speed up, but avoids producing noisy predictions as it slows down.

            break;

        }

        if (input_flags::enable_jerk_prediction_pruning()) {

            // TODO(b/266747654): Stop predictions if confidence is < some threshold

            // Arbitrarily high pruning index, will correct once jerk thresholding is implemented.

            const size_t upperBoundPredictionIndex = std::numeric_limits<size_t>::max();

            if (i > upperBoundPredictionIndex) {

                break;

            }

        }

        // TODO(b/266747654): Stop predictions if confidence is < some threshold.



        const TfLiteMotionPredictorSample::Point predictedPoint =

                convertPrediction(axisFrom, axisTo, predictedR[i], predictedPhi[i]);

libs/input/input_flags.aconfig

+0 −7
Original line number Diff line number Diff line
@@ -128,10 +128,3 @@ flag { 
  description: "Enable fling scrolling to be stopped by putting a finger on the touchpad again"

  bug: "281106755"

}
 


flag {

  name: "enable_jerk_prediction_pruning"

  namespace: "input"

  description: "Enable prediction pruning based on jerk thresholds."

  bug: "266747654"

}