Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f35ed439 authored by Sahana Rao's avatar Sahana Rao
Browse files

Hold a wake lock when taking bug report 

Bug: 128012377
Test: Turn the screen off after initiating bugreport,
      Bugreport takes 2-5 minutes now, same takes around 30-40 minutes
      without wake lock.
Test: Added debug messages in SystemSuspend logs to confirm
      wake lock cleanup on dumpstate crash/exit.
Change-Id: Idbd2466e1d67e0157657f587cf951e9bc4a1ea05
parent a18cfb64

cmds/dumpstate/Android.bp

+1 −0
Original line number Diff line number Diff line
@@ -86,6 +86,7 @@ cc_defaults { 
        "libdumpstateaidl",

        "libdumpstateutil",

        "libdumputils",

        "libhardware_legacy",

        "libhidlbase",

        "libhidltransport",

        "liblog",

cmds/dumpstate/DumpstateInternal.cpp

+7 −1
Original line number Diff line number Diff line
@@ -68,7 +68,8 @@ bool DropRootUser() { 
    }



    static const std::vector<std::string> group_names{

        "log", "sdcard_r", "sdcard_rw", "mount", "inet", "net_bw_stats", "readproc", "bluetooth"};

        "log", "sdcard_r", "sdcard_rw", "mount", "inet", "net_bw_stats",

            "readproc", "bluetooth", "wakelock"};

    std::vector<gid_t> groups(group_names.size(), 0);

    for (size_t i = 0; i < group_names.size(); ++i) {

        grp = getgrnam(group_names[i].c_str());
@@ -116,6 +117,11 @@ bool DropRootUser() { 
        capdata[cap_syslog_index].effective |= cap_syslog_mask;

    }



    const uint32_t cap_block_suspend_mask = CAP_TO_MASK(CAP_BLOCK_SUSPEND);

    const uint32_t cap_block_suspend_index = CAP_TO_INDEX(CAP_BLOCK_SUSPEND);

    capdata[cap_block_suspend_index].permitted |= cap_block_suspend_mask;

    capdata[cap_block_suspend_index].effective |= cap_block_suspend_mask;



    if (capset(&capheader, &capdata[0]) != 0) {

        MYLOGE("capset({%#x, %#x}) failed: %s\n", capdata[0].effective,

               capdata[1].effective, strerror(errno));

cmds/dumpstate/dumpstate.cpp

+10 −0
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ 
#include <debuggerd/client.h>

#include <dumpsys.h>

#include <dumputils/dump_utils.h>

#include <hardware_legacy/power.h>

#include <hidl/ServiceManagement.h>

#include <openssl/sha.h>

#include <private/android_filesystem_config.h>
@@ -144,6 +145,8 @@ static Dumpstate& ds = Dumpstate::GetInstance(); 
    func_ptr(__VA_ARGS__);                                  \

    RETURN_IF_USER_DENIED_CONSENT();



static const char* WAKE_LOCK_NAME = "dumpstate_wakelock";



namespace android {

namespace os {

namespace {
@@ -2405,6 +2408,13 @@ Dumpstate::RunStatus Dumpstate::RunInternal(int32_t calling_uid, 


    MYLOGI("begin\n");



    if (acquire_wake_lock(PARTIAL_WAKE_LOCK, WAKE_LOCK_NAME) < 0) {

        MYLOGE("Failed to acquire wake lock: %s\n", strerror(errno));

    } else {

        // Wake lock will be released automatically on process death

        MYLOGD("Wake lock acquired.\n");

    }



    register_sig_handler();



    // TODO(b/111441001): maybe skip if already started?