Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2f40f4d authored by ramindani's avatar ramindani
Browse files

SF: Update the sequence of operation for frame rate override 

This change will freeze the timeline with the new rate generated
through the requestDisplayMode before updating the render rate for
frameRateOverride

BUG: 343603085
Test: atest libsurfaceflinger_unittest
Flag: com.android.graphics.surfaceflinger.flags.vrr_bugfix_dropped_frame
Change-Id: I4d1c8febe1203de11046f6b6f4a92dc5f29cfbb3
parent a3be80cb

services/surfaceflinger/Scheduler/Scheduler.cpp

+10 −2
Original line number Diff line number Diff line
@@ -1113,8 +1113,10 @@ auto Scheduler::applyPolicy(S Policy::*statePtr, T&& newState) -> GlobalSignals 
                                                .emitEvent = !choice.consideredSignals.idle});

        }



        frameRateOverridesChanged = updateFrameRateOverridesLocked(consideredSignals, modeOpt->fps);



        if (!FlagManager::getInstance().vrr_bugfix_dropped_frame()) {

            frameRateOverridesChanged =

                    updateFrameRateOverridesLocked(consideredSignals, modeOpt->fps);

        }

        if (mPolicy.modeOpt != modeOpt) {

            mPolicy.modeOpt = modeOpt;

            refreshRateChanged = true;
@@ -1129,6 +1131,12 @@ auto Scheduler::applyPolicy(S Policy::*statePtr, T&& newState) -> GlobalSignals 
    if (refreshRateChanged) {

        mSchedulerCallback.requestDisplayModes(std::move(modeRequests));

    }



    if (FlagManager::getInstance().vrr_bugfix_dropped_frame()) {

        std::scoped_lock lock(mPolicyLock);

        frameRateOverridesChanged =

                updateFrameRateOverridesLocked(consideredSignals, mPolicy.modeOpt->fps);

    }

    if (frameRateOverridesChanged) {

        mSchedulerCallback.triggerOnFrameRateOverridesChanged();

    }