Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f2156e1a authored by Alec Mouri's avatar Alec Mouri
Browse files

Remove hot-path logging 

Turns out debug logging isn't cheap. Keeping the trace so that we can
still track it.

Bug: 144289346
Test: builds
Change-Id: I5d04f0d7821f89f1fe471ee67b165deef249ab50
parent 9adccca5

services/surfaceflinger/SurfaceFlinger.cpp

+2 −6
Original line number Original line Diff line number Diff line
@@ -1917,14 +1917,10 @@ void SurfaceFlinger::onMessageInvalidate(nsecs_t expectedVSyncTime) NO_THREAD_SA 
            const nsecs_t jankDuration = currentTime - mMissedFrameJankStart;

            const nsecs_t jankDuration = currentTime - mMissedFrameJankStart;

            if (jankDuration > kMinJankyDuration && jankDuration < kMaxJankyDuration) {

            if (jankDuration > kMinJankyDuration && jankDuration < kMaxJankyDuration) {

                ATRACE_NAME("Jank detected");

                ATRACE_NAME("Jank detected");

                ALOGD("Detected janky event. Missed frames: %d", mMissedFrameJankCount);

                const int32_t jankyDurationMillis = jankDuration / (1000 * 1000);

                const int32_t jankyDurationMillis = jankDuration / (1000 * 1000);

                {

                    ATRACE_NAME("Pushing to statsd");

                android::util::stats_write(android::util::DISPLAY_JANK_REPORTED,

                android::util::stats_write(android::util::DISPLAY_JANK_REPORTED,

                                           jankyDurationMillis, mMissedFrameJankCount);

                                           jankyDurationMillis, mMissedFrameJankCount);

            }

            }

            }





            // We either reported a jank event or we missed the trace

            // We either reported a jank event or we missed the trace

            // window, so clear counters here.

            // window, so clear counters here.