Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0a0c071 authored by Steven Moreland's avatar Steven Moreland Committed by Gerrit Code Review
Browse files

Merge "libbinder: softer error for linkToDeath lack of threads"

parents 96d426fb 5ec743f6

libs/binder/BpBinder.cpp

+1 −1
Original line number Original line Diff line number Diff line
@@ -388,7 +388,7 @@ status_t BpBinder::linkToDeath( 
{

{

    if (isRpcBinder()) {

    if (isRpcBinder()) {

        if (rpcSession()->getMaxIncomingThreads() < 1) {

        if (rpcSession()->getMaxIncomingThreads() < 1) {

            LOG_ALWAYS_FATAL("Cannot register a DeathRecipient without any incoming connections.");

            ALOGE("Cannot register a DeathRecipient without any incoming connections.");

            return INVALID_OPERATION;

            return INVALID_OPERATION;

        }

        }

    } else if constexpr (!kEnableKernelIpc) {

    } else if constexpr (!kEnableKernelIpc) {

libs/binder/tests/binderRpcTest.cpp

+2 −3
Original line number Original line Diff line number Diff line
@@ -683,7 +683,7 @@ TEST_P(BinderRpc, SingleDeathRecipientOnShutdown) { 
    proc.expectAlreadyShutdown = true;

    proc.expectAlreadyShutdown = true;

}

}





TEST_P(BinderRpc, DeathRecipientFatalWithoutIncoming) {

TEST_P(BinderRpc, DeathRecipientFailsWithoutIncoming) {

    class MyDeathRec : public IBinder::DeathRecipient {

    class MyDeathRec : public IBinder::DeathRecipient {

    public:

    public:

        void binderDied(const wp<IBinder>& /* who */) override {}

        void binderDied(const wp<IBinder>& /* who */) override {}
@@ -693,8 +693,7 @@ TEST_P(BinderRpc, DeathRecipientFatalWithoutIncoming) { 
            {.numThreads = 1, .numSessions = 1, .numIncomingConnections = 0});

            {.numThreads = 1, .numSessions = 1, .numIncomingConnections = 0});





    auto dr = sp<MyDeathRec>::make();

    auto dr = sp<MyDeathRec>::make();

    EXPECT_DEATH(proc.rootBinder->linkToDeath(dr, (void*)1, 0),

    EXPECT_EQ(INVALID_OPERATION, proc.rootBinder->linkToDeath(dr, (void*)1, 0));

                 "Cannot register a DeathRecipient without any incoming connections.");

}

}





TEST_P(BinderRpc, UnlinkDeathRecipient) {

TEST_P(BinderRpc, UnlinkDeathRecipient) {