Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit edcc7307 authored by Arpit Singh's avatar Arpit Singh
Browse files

[10/n Dispatcher refactor] Move obscuring related methods to WindowInfo 

In this CL we move following methods of WindowInfo subclass
1. isWindowObscured
2. isWindowObscuredAtPoint
3. findWallpaperWindowBelow

Bug: 367661487
Bug: 245989146
Test: atest inputflinger_tests
Flag: EXEMPT refactor
Change-Id: Ie7a00d485ee3a7299ce76318ad0252491606f5d0
parent ae8afff5

services/inputflinger/dispatcher/InputDispatcher.cpp

+18 −19
Original line number Diff line number Diff line
@@ -2504,9 +2504,9 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio 
            if (isSplit) {

                targetFlags |= InputTarget::Flags::SPLIT;

            }

            if (isWindowObscuredAtPointLocked(windowHandle, x, y)) {

            if (mWindowInfos.isWindowObscuredAtPoint(windowHandle, x, y)) {

                targetFlags |= InputTarget::Flags::WINDOW_IS_OBSCURED;

            } else if (isWindowObscuredLocked(windowHandle)) {

            } else if (mWindowInfos.isWindowObscured(windowHandle)) {

                targetFlags |= InputTarget::Flags::WINDOW_IS_PARTIALLY_OBSCURED;

            }
@@ -2537,7 +2537,8 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio 
                if (isDownOrPointerDown && targetFlags.test(InputTarget::Flags::FOREGROUND) &&

                    windowHandle->getInfo()->inputConfig.test(

                            gui::WindowInfo::InputConfig::DUPLICATE_TOUCH_TO_WALLPAPER)) {

                    sp<WindowInfoHandle> wallpaper = findWallpaperWindowBelow(windowHandle);

                    sp<WindowInfoHandle> wallpaper =

                            mWindowInfos.findWallpaperWindowBelow(windowHandle);

                    if (wallpaper != nullptr) {

                        ftl::Flags<InputTarget::Flags> wallpaperFlags =

                                InputTarget::Flags::WINDOW_IS_OBSCURED |
@@ -2650,9 +2651,9 @@ InputDispatcher::findTouchedWindowTargetsLocked(nsecs_t currentTime, const Motio 
                if (isSplit) {

                    targetFlags |= InputTarget::Flags::SPLIT;

                }

                if (isWindowObscuredAtPointLocked(newTouchedWindowHandle, x, y)) {

                if (mWindowInfos.isWindowObscuredAtPoint(newTouchedWindowHandle, x, y)) {

                    targetFlags |= InputTarget::Flags::WINDOW_IS_OBSCURED;

                } else if (isWindowObscuredLocked(newTouchedWindowHandle)) {

                } else if (mWindowInfos.isWindowObscured(newTouchedWindowHandle)) {

                    targetFlags |= InputTarget::Flags::WINDOW_IS_PARTIALLY_OBSCURED;

                }
@@ -3177,29 +3178,27 @@ bool InputDispatcher::isTouchTrustedLocked( 
    return true;

}



bool InputDispatcher::isWindowObscuredAtPointLocked(const sp<WindowInfoHandle>& windowHandle,

                                                    float x, float y) const {

bool InputDispatcher::DispatcherWindowInfo::isWindowObscuredAtPoint(

        const sp<WindowInfoHandle>& windowHandle, float x, float y) const {

    ui::LogicalDisplayId displayId = windowHandle->getInfo()->displayId;

    const std::vector<sp<WindowInfoHandle>>& windowHandles =

            mWindowInfos.getWindowHandlesForDisplay(displayId);

    const std::vector<sp<WindowInfoHandle>>& windowHandles = getWindowHandlesForDisplay(displayId);

    for (const sp<WindowInfoHandle>& otherHandle : windowHandles) {

        if (windowHandle == otherHandle) {

            break; // All future windows are below us. Exit early.

        }

        const WindowInfo* otherInfo = otherHandle->getInfo();

        if (canBeObscuredBy(windowHandle, otherHandle) &&

            windowOccludesTouchAt(*otherInfo, displayId, x, y,

                                  mWindowInfos.getDisplayTransform(displayId))) {

            windowOccludesTouchAt(*otherInfo, displayId, x, y, getDisplayTransform(displayId))) {

            return true;

        }

    }

    return false;

}



bool InputDispatcher::isWindowObscuredLocked(const sp<WindowInfoHandle>& windowHandle) const {

bool InputDispatcher::DispatcherWindowInfo::isWindowObscured(

        const sp<WindowInfoHandle>& windowHandle) const {

    ui::LogicalDisplayId displayId = windowHandle->getInfo()->displayId;

    const std::vector<sp<WindowInfoHandle>>& windowHandles =

            mWindowInfos.getWindowHandlesForDisplay(displayId);

    const std::vector<sp<WindowInfoHandle>>& windowHandles = getWindowHandlesForDisplay(displayId);

    const WindowInfo* windowInfo = windowHandle->getInfo();

    for (const sp<WindowInfoHandle>& otherHandle : windowHandles) {

        if (windowHandle == otherHandle) {
@@ -7049,7 +7048,7 @@ bool InputDispatcher::shouldDropInput( 
    if (windowHandle->getInfo()->inputConfig.test(WindowInfo::InputConfig::DROP_INPUT) ||

        (windowHandle->getInfo()->inputConfig.test(

                 WindowInfo::InputConfig::DROP_INPUT_IF_OBSCURED) &&

         isWindowObscuredLocked(windowHandle))) {

         mWindowInfos.isWindowObscured(windowHandle))) {

        ALOGW("Dropping %s event targeting %s as requested by the input configuration {%s} on "

              "display %s.",

              ftl::enum_string(entry.type).c_str(), windowHandle->getName().c_str(),
@@ -7102,7 +7101,7 @@ void InputDispatcher::slipWallpaperTouch(ftl::Flags<InputTarget::Flags> targetFl 
    const sp<WindowInfoHandle> oldWallpaper =

            oldHasWallpaper ? state.getWallpaperWindow(deviceId) : nullptr;

    const sp<WindowInfoHandle> newWallpaper =

            newHasWallpaper ? findWallpaperWindowBelow(newWindowHandle) : nullptr;

            newHasWallpaper ? mWindowInfos.findWallpaperWindowBelow(newWindowHandle) : nullptr;

    if (oldWallpaper == newWallpaper) {

        return;

    }
@@ -7139,7 +7138,7 @@ void InputDispatcher::transferWallpaperTouch( 
    const sp<WindowInfoHandle> oldWallpaper =

            oldHasWallpaper ? state.getWallpaperWindow(deviceId) : nullptr;

    const sp<WindowInfoHandle> newWallpaper =

            newHasWallpaper ? findWallpaperWindowBelow(toWindowHandle) : nullptr;

            newHasWallpaper ? mWindowInfos.findWallpaperWindowBelow(toWindowHandle) : nullptr;

    if (oldWallpaper == newWallpaper) {

        return;

    }
@@ -7171,10 +7170,10 @@ void InputDispatcher::transferWallpaperTouch( 
    }

}



sp<WindowInfoHandle> InputDispatcher::findWallpaperWindowBelow(

sp<WindowInfoHandle> InputDispatcher::DispatcherWindowInfo::findWallpaperWindowBelow(

        const sp<WindowInfoHandle>& windowHandle) const {

    const std::vector<sp<WindowInfoHandle>>& windowHandles =

            mWindowInfos.getWindowHandlesForDisplay(windowHandle->getInfo()->displayId);

            getWindowHandlesForDisplay(windowHandle->getInfo()->displayId);

    bool foundWindow = false;

    for (const sp<WindowInfoHandle>& otherHandle : windowHandles) {

        if (!foundWindow && otherHandle != windowHandle) {

services/inputflinger/dispatcher/InputDispatcher.h

+8 −7
Original line number Diff line number Diff line
@@ -325,6 +325,14 @@ private: 
        TouchOcclusionInfo computeTouchOcclusionInfo(

                const sp<android::gui::WindowInfoHandle>& windowHandle, float x, float y) const;



        bool isWindowObscured(const sp<android::gui::WindowInfoHandle>& windowHandle) const;



        bool isWindowObscuredAtPoint(const sp<android::gui::WindowInfoHandle>& windowHandle,

                                     float x, float y) const;



        sp<android::gui::WindowInfoHandle> findWallpaperWindowBelow(

                const sp<android::gui::WindowInfoHandle>& windowHandle) const;



        std::string dumpDisplayAndWindowInfo() const;



    private:
@@ -639,10 +647,6 @@ private: 


    bool isTouchTrustedLocked(const DispatcherWindowInfo::TouchOcclusionInfo& occlusionInfo) const

            REQUIRES(mLock);

    bool isWindowObscuredAtPointLocked(const sp<android::gui::WindowInfoHandle>& windowHandle,

                                       float x, float y) const REQUIRES(mLock);

    bool isWindowObscuredLocked(const sp<android::gui::WindowInfoHandle>& windowHandle) const

            REQUIRES(mLock);

    std::string getApplicationWindowLabel(const InputApplicationHandle* applicationHandle,

                                          const sp<android::gui::WindowInfoHandle>& windowHandle);
@@ -795,9 +799,6 @@ private: 
                                const std::unique_ptr<trace::EventTrackerInterface>& traceTracker)

            REQUIRES(mLock);



    sp<android::gui::WindowInfoHandle> findWallpaperWindowBelow(

            const sp<android::gui::WindowInfoHandle>& windowHandle) const REQUIRES(mLock);



    /** Stores the value of the input flag for per device input latency metrics. */

    const bool mPerDeviceInputLatencyMetricsFlag =

            com::android::input::flags::enable_per_device_input_latency_metrics();