Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ed63f352 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: Status s/stringstream/ostream/ 

stringstream extends ostream, so this is just generally more useful.
I'm tired of having to lookup that I need to use 'Status::toString8' in
order to print it out.

Test: m camera_client_test (uses API, motived last change here)
Test: grep most internal prebuilts for
_ZN7android6binderlsERNSt3__118basic_stringstreamIcNS1_11char_traitsIcEENS1_9allocatorIcEEEERKNS0_6StatusE

Change-Id: I7ed88a3ecf8b560302697e4c5c2357acc05c20fa
parent 05f351cb

libs/binder/Status.cpp

+0 −5
Original line number Diff line number Diff line
@@ -245,10 +245,5 @@ String8 Status::toString8() const { 
    return ret;

}



std::stringstream& operator<< (std::stringstream& stream, const Status& s) {

    stream << s.toString8().string();

    return stream;

}



}  // namespace binder

}  // namespace android

libs/binder/include/binder/Status.h

+5 −3
Original line number Diff line number Diff line
@@ -18,7 +18,8 @@ 
#define ANDROID_BINDER_STATUS_H



#include <cstdint>

#include <sstream>

#include <sstream> // historical

#include <ostream>



#include <binder/Parcel.h>

#include <utils/String8.h>
@@ -153,8 +154,9 @@ private: 
    String8 mMessage;

};  // class Status



// For gtest output logging

std::stringstream& operator<< (std::stringstream& stream, const Status& s);

static inline std::ostream& operator<< (std::ostream& o, const Status& s) {

    return o << s.toString8();

}



}  // namespace binder

}  // namespace android