Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e678897f authored by Nick Kralevich's avatar Nick Kralevich Committed by Gerrit Code Review
Browse files

Merge "Proper security labeling of multi-user data directories."

parents 1852eb4f 880d1a95

cmds/installd/commands.c

+2 −2
Original line number Diff line number Diff line
@@ -184,7 +184,7 @@ int delete_user_data(const char *pkgname, uid_t persona) 
    return delete_dir_contents(pkgdir, 0, "lib");

}



int make_user_data(const char *pkgname, uid_t uid, uid_t persona)

int make_user_data(const char *pkgname, uid_t uid, uid_t persona, const char* seinfo)

{

    char pkgdir[PKG_PATH_MAX];

    char applibdir[PKG_PATH_MAX];
@@ -245,7 +245,7 @@ int make_user_data(const char *pkgname, uid_t uid, uid_t persona) 
        return -1;

    }



    if (selinux_android_setfilecon(pkgdir, pkgname, uid) < 0) {

    if (selinux_android_setfilecon2(pkgdir, pkgname, seinfo, uid) < 0) {

        ALOGE("cannot setfilecon dir '%s': %s\n", pkgdir, strerror(errno));

        unlink(libsymlink);

        unlink(pkgdir);

cmds/installd/installd.c

+3 −2
Original line number Diff line number Diff line
@@ -103,7 +103,8 @@ static int do_rm_user_data(char **arg, char reply[REPLY_MAX]) 


static int do_mk_user_data(char **arg, char reply[REPLY_MAX])

{

    return make_user_data(arg[0], atoi(arg[1]), atoi(arg[2])); /* pkgname, uid, userid */

    return make_user_data(arg[0], atoi(arg[1]), atoi(arg[2]), arg[3]);

                             /* pkgname, uid, userid, seinfo */

}



static int do_rm_user(char **arg, char reply[REPLY_MAX])
@@ -142,7 +143,7 @@ struct cmdinfo cmds[] = { 
    { "rmuserdata",           2, do_rm_user_data },

    { "movefiles",            0, do_movefiles },

    { "linklib",              3, do_linklib },

    { "mkuserdata",           3, do_mk_user_data },

    { "mkuserdata",           4, do_mk_user_data },

    { "rmuser",               1, do_rm_user },

};

cmds/installd/installd.h

+1 −1
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ int uninstall(const char *pkgname, uid_t persona); 
int renamepkg(const char *oldpkgname, const char *newpkgname);

int fix_uid(const char *pkgname, uid_t uid, gid_t gid);

int delete_user_data(const char *pkgname, uid_t persona);

int make_user_data(const char *pkgname, uid_t uid, uid_t persona);

int make_user_data(const char *pkgname, uid_t uid, uid_t persona, const char* seinfo);

int delete_persona(uid_t persona);

int delete_cache(const char *pkgname, uid_t persona);

int move_dex(const char *src, const char *dst);