Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit df5607be authored by Steven Moreland's avatar Steven Moreland
Browse files

RPC Binder: log one more low memory case 

We don't typically log in allocation failure, but this would
be good evidence of the bug here.

Bug: 404210068
Test: binderRpcTest
Change-Id: I2522b772082240124040bd8e346b8971deed28bb
parent 81acc44a

libs/binder/RpcState.cpp

+13 −1
Original line number Diff line number Diff line
@@ -358,7 +358,19 @@ RpcState::CommandData::CommandData(size_t size) : mSize(size) { 
    } else if (size > binder::kLogTransactionsOverBytes) {

        ALOGW("Transaction too large: inefficient and in danger of breaking: %zu bytes.", size);

    }

    mData.reset(new (std::nothrow) uint8_t[size]);



    // must always be written over

    uint8_t* data = new (std::nothrow) uint8_t[size];



    if (!data) {

        // For helping debug b/404210068. If we are running out of memory,

        // then, as Android is today, it's going down no matter what we do.

        // However, if we can get data out of this process, go ahead and log

        // to help us debug this bug.

        ALOGE("Failed to allocate %zu data.", size);

    }



    mData.reset(data);

}



status_t RpcState::rpcSend(const sp<RpcSession::RpcConnection>& connection,