Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ddd61e27 authored by Steven Moreland's avatar Steven Moreland
Browse files

Revert "RPC Binder: terminate session for bad dec strong" 

This reverts commit e0cb1808.

Reason for revert: b/417832354 - this error appears to happen
sometimes for binder objects that die, causing a flake in one
of our tests. This needs to be relanded with appropriate test or
libbinder fixes.

Bug: 416772676
Fixes: 417832354
Change-Id: Ib60a821ac397fa477e9e9eb35dc2edb7746423a3
parent e0cb1808

libs/binder/RpcState.cpp

+2 −3
Original line number Diff line number Diff line
@@ -1206,9 +1206,8 @@ status_t RpcState::processDecStrong(const sp<RpcSession::RpcConnection>& connect 
    RpcMutexUniqueLock _l(mNodeMutex);

    auto it = mNodeForAddress.find(addr);

    if (it == mNodeForAddress.end()) {

        ALOGE("Unknown binder address %" PRIu64 " for dec strong. Terminating!", addr);

        (void)session->shutdownAndWait(false);

        return BAD_VALUE;

        ALOGE("Unknown binder address %" PRIu64 " for dec strong.", addr);

        return OK;

    }



    sp<IBinder> target = it->second.binder.promote();