Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d5186bbc authored by Patrick Williams's avatar Patrick Williams
Browse files

Log fatal if we fail to apply a transaction in acquireNextBufferLocked 

Failing to apply a transaction here would leave BBQ in an invalid state and lead to confusing
issues (e.g. running out of buffer).

Bug: 413847854
Flag: EXEMPT log only update
Test: presubmits
Change-Id: I85c5248ad0fb8e4e65d87a1ede545dadb8202bd2
parent 71d2535c

libs/gui/BLASTBufferQueue.cpp

+4 −1
Original line number Diff line number Diff line
@@ -702,7 +702,10 @@ status_t BLASTBufferQueue::acquireNextBufferLocked( 
    mergePendingTransactions(t, bufferItem.mFrameNumber);

    if (applyTransaction) {

        // All transactions on our apply token are one-way. See comment on mAppliedLastTransaction

        t->setApplyToken(mApplyToken).apply(false, true);

        status_t status = t->setApplyToken(mApplyToken).apply(false, true);

        LOG_ALWAYS_FATAL_IF(status != OK,

                            "[%s] acquireNextBufferLocked failed to apply transaction. status=%d",

                            mName.c_str(), status);

        mAppliedLastTransaction = true;

        mLastAppliedFrameNumber = bufferItem.mFrameNumber;

    } else {