Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d51820e8 authored by Nick Kralevich's avatar Nick Kralevich
Browse files

dumpstate: don't follow symlinks when creating /data/anr/traces.txt 

Make Android more robust against symlink attacks when /data/anr
is world-writable.

Bug: 5614000
Change-Id: I9a7e4c4ec9aa4300ac30a968db0dcd276f364ab6
parent c7f1fe26

cmds/dumpstate/utils.c

+1 −1
Original line number Diff line number Diff line
@@ -383,7 +383,7 @@ const char *dump_vm_traces() { 
    }



    /* create a new, empty traces.txt file to receive stack dumps */

    int fd = open(traces_path, O_CREAT | O_WRONLY | O_TRUNC, 0666);  /* -rw-rw-rw- */

    int fd = open(traces_path, O_CREAT | O_WRONLY | O_TRUNC | O_NOFOLLOW, 0666);  /* -rw-rw-rw- */

    if (fd < 0) {

        fprintf(stderr, "%s: %s\n", traces_path, strerror(errno));

        return NULL;