Commit cc5f5175 authored Mar 11, 2019 by Greg Kaiser

cmds/service: Fix categoryCount

By introducing a new 'categoryCount' in an inner scope, and only
incrementing it within this inner scope, we're assured that when
we leave this scope, our "if (categoryCount > 0)" will always
be false, not matter how 'categories' we added.

This almost certainly is not the intention of this code, so we
removing the inner scope declaration of the variable, so that
'categoryCount' will be updated.

Bug: 28288587
Test: TreeHugger
Change-Id: Ie592a02c5baa1eb5527ddd8d726e3b1181d937fd

parent 326456a2

cmds/service/service.cpp

+0 −1

Original line number	Diff line number	Diff line
		@@ -232,7 +232,6 @@ int main(int argc, char* const argv[])
		else if (strcmp(key, "categories") == 0)
		{
		char* context2 = nullptr;
		int categoryCount = 0;
		categories[categoryCount] = strtok_r(value, ",", &context2);

		while (categories[categoryCount] != nullptr)