Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5025370 authored by Harry Cutts's avatar Harry Cutts
Browse files

Put detailed touchpad gesture logs behind sysprop 

Logging every gesture recognized by the Gestures library is pretty
spammy, and since it allows the exact pointer movements and clicks to be
reconstructed we shouldn't have it on by default.

Bug: 251196347
Test: make gestures on pad, check no "Gesture ready" logs appear until
      the sysprop is turned on
Change-Id: I8b04a42579ec0a267e4f0248bc079b2468d76e80
parent b304b2f1

services/inputflinger/reader/mapper/TouchpadInputMapper.cpp

+10 −1
Original line number Diff line number Diff line
@@ -31,6 +31,15 @@ namespace android { 


namespace {



/**

 * Log details of each gesture output by the gestures library.

 * Enable this via "adb shell setprop log.tag.TouchpadInputMapperGestures DEBUG" (requires

 * restarting the shell)

 */

const bool DEBUG_TOUCHPAD_GESTURES =

        __android_log_is_loggable(ANDROID_LOG_DEBUG, "TouchpadInputMapperGestures",

                                  ANDROID_LOG_INFO);



// Describes a segment of the acceleration curve.

struct CurveSegment {

    // The maximum pointer speed which this segment should apply. The last segment in a curve should
@@ -259,7 +268,7 @@ std::list<NotifyArgs> TouchpadInputMapper::sendHardwareState(nsecs_t when, nsecs 
}



void TouchpadInputMapper::consumeGesture(const Gesture* gesture) {

    ALOGD("Gesture ready: %s", gesture->String().c_str());

    ALOGD_IF(DEBUG_TOUCHPAD_GESTURES, "Gesture ready: %s", gesture->String().c_str());

    if (!mProcessing) {

        ALOGE("Received gesture outside of the normal processing flow; ignoring it.");

        return;