Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd41dc1b authored by Devin Moore's avatar Devin Moore
Browse files

Clarify binder RPC error message with linkToDeath 

There needs to be threads for incoming connections before linking to
death so the service can get the notifications.

Test: none
Bug: none
Change-Id: I2e850de4fbb171b2b5c302c85980bb4966d73421
parent 355cafc8

libs/binder/BpBinder.cpp

+2 −1
Original line number Diff line number Diff line
@@ -388,7 +388,8 @@ status_t BpBinder::linkToDeath( 
{

    if (isRpcBinder()) {

        if (rpcSession()->getMaxIncomingThreads() < 1) {

            ALOGE("Cannot register a DeathRecipient without any incoming connections.");

            ALOGE("Cannot register a DeathRecipient without any incoming threads. Need to set max "

                  "incoming threads to a value greater than 0 before calling linkToDeath.");

            return INVALID_OPERATION;

        }

    } else if constexpr (!kEnableKernelIpc) {