Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bc2b607a authored by Gavin Corkery's avatar Gavin Corkery
Browse files

Make DumpstateListener onError method oneway 

The other change in this topic allows the onError
DumpstateListener call to be made asynchronous,
meaning that a blocking binder call will no longer be
made out of system_server.

Bug: 147703592
Test: Manual. Take bugreport, ensure that the death recipient
      logic never triggers before the onError/onFinished callback.
Change-Id: Ibb74bf068c4b186f07e19bb076b4ddea69eda768
parent 8592b080

cmds/dumpstate/binder/android/os/IDumpstateListener.aidl

+1 −5
Original line number Diff line number Diff line
@@ -21,8 +21,6 @@ package android.os; 
  *

  * <p>When bugreport creation is complete one of {@code onError} or {@code onFinished} is called.

  *

  * <p>These methods are synchronous by design in order to make dumpstate's lifecycle simpler

  * to handle.

  *

  * {@hide}

  */
@@ -54,10 +52,8 @@ interface IDumpstateListener { 


    /**

     * Called on an error condition with one of the error codes listed above.

     * This is not an asynchronous method since it can race with dumpstate exiting, thus triggering

     * death recipient.

     */

    void onError(int errorCode);

    oneway void onError(int errorCode);



    /**

     * Called when taking bugreport finishes successfully.