Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bad51959 authored by Konstantin Lopyrev's avatar Konstantin Lopyrev
Browse files

Fix 1684100: Making sure that empty package, type and resource ids are not accepted.

Change-Id: I4c94877e4312e9a5b4d22c8625069ca056c62e40
parent 265b59ab
Loading
Loading
Loading
Loading
+18 −0
Original line number Diff line number Diff line
@@ -2609,6 +2609,24 @@ bool ResTable::expandResourceRef(const uint16_t* refStr, size_t refLen,
        *outType = *defType;
    }
    *outName = String16(p, end-p);
    if(**outPackage == 0) {
        if(outErrorMsg) {
            *outErrorMsg = "Resource package cannot be an empty string";
        }
        return false;
    }
    if(**outType == 0) {
        if(outErrorMsg) {
            *outErrorMsg = "Resource type cannot be an empty string";
        }
        return false;
    }
    if(**outName == 0) {
        if(outErrorMsg) {
            *outErrorMsg = "Resource id cannot be an empty string";
        }
        return false;
    }
    return true;
}