Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6aa9a04 authored by Arthur Hung's avatar Arthur Hung
Browse files

Update transform hint from relayout window (2/2) 

The transform hint is used to prevent allocating a buffer of a different
size when a window is rotated. We return the fixed rotation transform
and pass it to BLASTBufferQueue so the producer can choose to consume
the hint and allocate the buffer with the same size.

Bug: 188893403
Bug: 177029197
Test: atest WmTests
Test: gfxbenchmark
Test: atest libsurfaceflinger_unittest SurfaceFlinger_test
Change-Id: I9fee3ab443e5f81d0209c62ad95c6355fa8dacee
parent f75789e7

libs/gui/BLASTBufferQueue.cpp

+5 −0
Original line number Diff line number Diff line
@@ -201,6 +201,11 @@ void BLASTBufferQueue::update(const sp<SurfaceControl>& surface, uint32_t width, 
        applyTransaction = true;

    }



    if (mSurfaceControl != nullptr) {

        mTransformHint = mSurfaceControl->getTransformHint();

        mBufferItemConsumer->setTransformHint(mTransformHint);

    }



    ui::Size newSize(width, height);

    if (mRequestedSize != newSize) {

        mRequestedSize.set(newSize);

services/surfaceflinger/SurfaceFlinger.cpp

+5 −1
Original line number Diff line number Diff line
@@ -2838,8 +2838,10 @@ void SurfaceFlinger::processDisplayChanged(const wp<IBinder>& displayToken, 
            (currentState.orientedDisplaySpaceRect != drawingState.orientedDisplaySpaceRect)) {

            display->setProjection(currentState.orientation, currentState.layerStackSpaceRect,

                                   currentState.orientedDisplaySpaceRect);

            if (display->isPrimary()) {

                mDefaultDisplayTransformHint = display->getTransformHint();

            }

        }

        if (currentState.width != drawingState.width ||

            currentState.height != drawingState.height) {

            display->setDisplaySize(currentState.width, currentState.height);
@@ -6875,6 +6877,8 @@ sp<Layer> SurfaceFlinger::handleLayerCreatedLocked(const sp<IBinder>& handle, bo 
        parent->addChild(layer);

    }



    layer->updateTransformHint(mDefaultDisplayTransformHint);



    if (state->initialProducer != nullptr) {

        mGraphicBufferProducerList.insert(state->initialProducer);

        LOG_ALWAYS_FATAL_IF(mGraphicBufferProducerList.size() > mMaxGraphicBufferProducerListSize,